twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Add tests for `modules/spreadsheet-import`

Open gitstart-twenty opened this issue 1 year ago • 4 comments

Scope & Context

This is a child issue of #2992 which addresses increasing test coverage for the front-end. This issue is for the increasing coverage for /modules/spreadsheet-import

gitstart-twenty avatar Jan 08 '24 17:01 gitstart-twenty

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-3316

gitstart-app[bot] avatar Jan 08 '24 18:01 gitstart-app[bot]

We are currently rewriting the spreadsheet import so might be best to put this on hold

FelixMalfait avatar Jan 09 '24 09:01 FelixMalfait

We are currently rewriting the spreadsheet import so might be best to put this on hold

Okay, @FelixMalfait

gitstart-twenty avatar Jan 09 '24 12:01 gitstart-twenty

Hey @FelixMalfait x @charlesBochet, Which of these are going to undergo changes/refactors in the near-future so we hold back on tests?

  • modules/object-record
  • modules/object-metadata
  • modules/navigation
  • modules/keyboard-shortcut-menu
  • modules/favorites
  • modules/companies
  • modules/command-menu
  • modules/auth
  • modules/apollo
  • modules/analytics

gitstart-twenty avatar Jan 09 '24 12:01 gitstart-twenty

Discussed with you! LGTM :)

charlesBochet avatar Jan 11 '24 11:01 charlesBochet

Discussed with you! LGTM :)

Okay

gitstart-twenty avatar Jan 11 '24 13:01 gitstart-twenty

Spreadsheet import has been refactored.

FelixMalfait avatar Feb 21 '24 15:02 FelixMalfait

@gitstart-twenty could you pick this ticket?

charlesBochet avatar Feb 21 '24 17:02 charlesBochet

@gitstart-twenty could you pick this ticket?

Yes, please

gitstart-twenty avatar Feb 22 '24 03:02 gitstart-twenty

Thank you!

charlesBochet avatar Feb 22 '24 09:02 charlesBochet