twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Filter the opportunities "Point of contact" field

Open gitstart-twenty opened this issue 1 year ago • 3 comments

Fixes #2632

gitstart-twenty avatar Jan 02 '24 04:01 gitstart-twenty

@gitstart-twenty Is this PR ready for review?

@lucasbordeau I believe you are the biggest export of this section, especially with your work on Activities, assigning it to you

charlesBochet avatar Jan 03 '24 21:01 charlesBochet

@gitstart-twenty any update on this one?

charlesBochet avatar Jan 08 '24 20:01 charlesBochet

@gitstart-twenty any update on this one?

We should get this today

gitstart-twenty avatar Jan 09 '24 06:01 gitstart-twenty

Following my comments on naming, could you refactor a bit the placeholders :

See in FullNameFieldInput.tsx :

const FIRST_NAME_PLACEHOLDER_WITH_SPECIAL_CHARACTER_TO_AVOID_PASSWORD_MANAGERS =
  'F‌‌irst name';

const LAST_NAME_PLACEHOLDER_WITH_SPECIAL_CHARACTER_TO_AVOID_PASSWORD_MANAGERS =
  'L‌‌ast name';

(By the way you can see that we use long naming with context when we need to)

And use those constants in the creation fields too.

lucasbordeau avatar Jan 10 '24 18:01 lucasbordeau

To complete the issue :

  • When we are on create mode, you can remove the picker, just keep the creation component
  • When we're finished with the creation, assign the new Person to the card and close the field.

lucasbordeau avatar Jan 10 '24 18:01 lucasbordeau

Hey @lucasbordeau This has been updated

https://github.com/twentyhq/twenty/assets/140154534/af03c708-1819-4540-b727-6cd858ea2de1

gitstart-twenty avatar Jan 11 '24 11:01 gitstart-twenty

@gitstart-twenty Bazinga !

lucasbordeau avatar Jan 11 '24 19:01 lucasbordeau

@gitstart-twenty Bazinga !

@lucasbordeau

https://github.com/twentyhq/twenty/assets/140154534/e565f03d-a1ac-4392-ba19-b253c75020f3

gitstart-twenty avatar Jan 11 '24 20:01 gitstart-twenty