twenty
twenty copied to clipboard
Filter the opportunities "Point of contact" field
Fixes #2632
@gitstart-twenty Is this PR ready for review?
@lucasbordeau I believe you are the biggest export of this section, especially with your work on Activities, assigning it to you
@gitstart-twenty any update on this one?
@gitstart-twenty any update on this one?
We should get this today
Following my comments on naming, could you refactor a bit the placeholders :
See in FullNameFieldInput.tsx
:
const FIRST_NAME_PLACEHOLDER_WITH_SPECIAL_CHARACTER_TO_AVOID_PASSWORD_MANAGERS =
'First name';
const LAST_NAME_PLACEHOLDER_WITH_SPECIAL_CHARACTER_TO_AVOID_PASSWORD_MANAGERS =
'Last name';
(By the way you can see that we use long naming with context when we need to)
And use those constants in the creation fields too.
To complete the issue :
- When we are on create mode, you can remove the picker, just keep the creation component
- When we're finished with the creation, assign the new Person to the card and close the field.
Hey @lucasbordeau This has been updated
https://github.com/twentyhq/twenty/assets/140154534/af03c708-1819-4540-b727-6cd858ea2de1
@gitstart-twenty Bazinga !
@gitstart-twenty Bazinga !
@lucasbordeau
https://github.com/twentyhq/twenty/assets/140154534/e565f03d-a1ac-4392-ba19-b253c75020f3