twenty
twenty copied to clipboard
twentyhq
Add scroll to left-side menu
People have been playing around creating objects on the demo and it shows that left-side menu doesn't behave properly when there is a large number of items. We should introduce a scroll.
@FelixMalfait Came across this and put a PR fix up here - https://github.com/twentyhq/twenty/pull/3187 @Kanav-Arora apologies if I got to this before you, but feel free to look it over.
@jordan-sussman its a standard practice to raise PR post allocation of issue. @FelixMalfait you should add this to contribution guideline as with increase in popularity of repo there will be multiple PRs for same issue and I think this should not be entertained
I think it's best to start a pr if there's no PR linked to this issue and keep it as a draft pr, so that other contributors can see that there's someone already working.
If someone can only create a PR after getting assigned, then it should be mentioned clearly in the contribution instruction.
@jordan-sussman thanks! @Kanav-Arora I understand the frustration but it starts from a good intention, and it's such a small fix that it's not like there's ongoing work that's getting lost :)
I agree with you @Kanav-Arora @dotslashbit that we need to clarify the rules to find a good balance between people getting assigned but not doing the tasks, and people doing duplicated work because of lack of assignation. We'll brainstorm and update within a few weeks, along with the new contributors page / probably some form of non-monetary reward program. It's a great problem to have - we're lucky to have all this community support!