twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Table Views - Temporary View

Open thaisguigon opened this issue 1 year ago • 2 comments

Context

See #3099

For this issue, following #3125:

  • In the table page, when temporary view filters for this table are set:
    • Display "Back to [record label]" in place of the breadcrumb (to refine: use url parameters? Recoil State?)
    • Display the Object's icon + label in place of the View selector.
    • Disable removing the current filters.
    • Do not show the Object as "Active" in the Nav's Workspace section. Clicking on it removes the temporary filters.

Figma

image

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=17774%3A52894&mode=dev

thaisguigon avatar Dec 22 '23 11:12 thaisguigon

Note: I don't think we should call this "temporary view". For me this is the page for /objectName?view=null- it's not temporary, will always be there :)

FelixMalfait avatar Dec 30 '23 14:12 FelixMalfait

@FelixMalfait For now the way I implemented it for sake of simplicity, I use the currently selected view but I override only the View Filters (without persisting them). The user can persist the filters to the currently selected view if they want. This is simpler because I only need to override the View Filters, otherwise I would need to provide the View Fields for the "none" view as well. But this can be changed later so we use all the available View Fields. Also, the feature was named "Temporary filtered index" in the original issue written by @Bonapara: https://github.com/twentyhq/twenty/issues/3099

thaisguigon avatar Jan 08 '24 11:01 thaisguigon

Closed in favor of: https://github.com/twentyhq/twenty/issues/4093

thaisguigon avatar Mar 04 '24 16:03 thaisguigon