twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Fix dark mode light box shadow

Open Bonapara opened this issue 1 year ago • 10 comments

Context

On dark mode, the icon button box shadow is white. It should be dark in both light and dark mode:

Current behavior

Screenshot 2023-12-19 at 18 59 41

Desired behavior

  • Apply the same box shadow to dark mode as the one used for light mode.
  • Remove the "Scale" effect when hovering over the button, but retain the colored hover effect.

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=3063-45160&mode=design&t=JJOijbrWPEg9mHWr-11

Bonapara avatar Dec 19 '23 18:12 Bonapara

Hi @Bonapara I can work on this

Kanav-Arora avatar Dec 20 '23 05:12 Kanav-Arora

Hi @charlesBochet

The box shadow used for these buttons is hard coded that's why its different in dark mode and no matching shadows exists for now. So should I create one?

Screenshot 2023-12-21 at 10 30 53 PM

Kanav-Arora avatar Dec 21 '23 17:12 Kanav-Arora

@Kanav-Arora good point https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=2993%3A39004&mode=dev Let's use the boxShadow light from the theme

charlesBochet avatar Dec 21 '23 17:12 charlesBochet

@Kanav-Arora good point https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=2993%3A39004&mode=dev Let's use the boxShadow light from the theme

I tried but it looks really dull as the pixels are same but the color is dull in light

Kanav-Arora avatar Dec 21 '23 18:12 Kanav-Arora

ok! so it means that the design system should be adjusted. That's a question for @Bonapara to answer :)

charlesBochet avatar Dec 21 '23 18:12 charlesBochet

ok! so it means that the design system should be adjusted. That's a question for @Bonapara to answer :)

Wait see below screenshot with light boxshadow Please check if this looks okay

Screenshot 2023-12-22 at 12 03 39 AM Screenshot 2023-12-22 at 12 04 11 AM

Kanav-Arora avatar Dec 21 '23 18:12 Kanav-Arora

Hi @Bonapara @charlesBochet Is this okay?

Kanav-Arora avatar Dec 23 '23 12:12 Kanav-Arora

Hi @Bonapara Please take a look at this

Kanav-Arora avatar Dec 30 '23 10:12 Kanav-Arora

Hi @Kanav-Arora! Happy New Year! Yes, it's a good temporary solution. I'll address the floating buttons in a future issue to enhance their design for dark mode.

Bonapara avatar Jan 02 '24 10:01 Bonapara

Hi @Bonapara Happy New Year to you too! May this year brings happiness to your family. Cool I'll raise a PR for this

Kanav-Arora avatar Jan 02 '24 12:01 Kanav-Arora