twenty
twenty copied to clipboard
Fix dark mode light box shadow
Context
On dark mode, the icon button box shadow is white. It should be dark in both light and dark mode:
Current behavior
Desired behavior
- Apply the same box shadow to dark mode as the one used for light mode.
- Remove the "Scale" effect when hovering over the button, but retain the colored hover effect.
https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=3063-45160&mode=design&t=JJOijbrWPEg9mHWr-11
Hi @Bonapara I can work on this
Hi @charlesBochet
The box shadow used for these buttons is hard coded that's why its different in dark mode and no matching shadows exists for now. So should I create one?
@Kanav-Arora good point
https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=2993%3A39004&mode=dev
Let's use the boxShadow light
from the theme
@Kanav-Arora good point https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=2993%3A39004&mode=dev Let's use the boxShadow
light
from the theme
I tried but it looks really dull as the pixels are same but the color is dull in light
ok! so it means that the design system should be adjusted. That's a question for @Bonapara to answer :)
ok! so it means that the design system should be adjusted. That's a question for @Bonapara to answer :)
Wait see below screenshot with light
boxshadow
Please check if this looks okay
Hi @Bonapara @charlesBochet Is this okay?
Hi @Bonapara Please take a look at this
Hi @Kanav-Arora! Happy New Year! Yes, it's a good temporary solution. I'll address the floating buttons in a future issue to enhance their design for dark mode.
Hi @Bonapara Happy New Year to you too! May this year brings happiness to your family. Cool I'll raise a PR for this