twenty
twenty copied to clipboard
Forbid the creation of field named "and", "or" and "not"
Scope & Context
In standard field features, and custom field creation.
Current behavior
We can currently input anything we want in a field name's singular or plural.
Expected behavior
In this case we want to forbid using pg_graphql's reserved operator for filtering. See https://supabase.github.io/pg_graphql/api/#filtering
Avoid naming your columns and, or or not. If you do, the corresponding filter operator will not be available for use.
Note that there could be other words we would want to forbid as well.
We would want to forbid this on the backend endpoint and also in the front end on field creation / update.
@lucasbordeau can I be work on this.
See also #2146 which is similar. Maybe we should just do 1 regex for both object name and field name
@mozesi I'm sorry we didn't reply, if you're still interested let us know!
@FelixMalfait am still interested.
Great! Assigned you :). Thanks a lot!
@mozesi any progress on this? Thanks!
@FelixMalfait you could assign it to me. I can give it a shot
Great thanks!
@FelixMalfait We can close this issue I am assuming?
Ah indeed thanks @AbuHafsa!