twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Missing bottom margin and unexpected left margin

Open charlesBochet opened this issue 1 year ago • 4 comments

Bug Description

I've noticed to regressions on the design: image

  1. We are missing a 12px bottom margin or padding: image

See: https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=568%3A41661&mode=dev

  1. We have an additional 12px left margin or padding on the main container: image

This left margin should not exist. I suspect that we have mixed things while working on responsiveness.

Expected behavior

  • 12px bottom margin
  • no additional 12px left margin

Compare with Figma: https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=478%3A19796&mode=dev

Technical inputs

However, make sure the behavior on mobile (screen with small width) do not change. You might have to use useIsMobile if these margins are useful on mobile

charlesBochet avatar Dec 18 '23 08:12 charlesBochet

@Bonapara FYI so you don't re-create it!

charlesBochet avatar Dec 18 '23 08:12 charlesBochet

may i take this issue?

HuijungYoon avatar Dec 18 '23 12:12 HuijungYoon

Sure! Thank you!

charlesBochet avatar Dec 18 '23 13:12 charlesBochet

@HuijungYoon As this issue needs to be fixed before 0.2.2 release, I will tackle it, feel free to take any other good first issue :)

charlesBochet avatar Dec 21 '23 19:12 charlesBochet

This was fixed. Closing!

FelixMalfait avatar Jan 17 '24 11:01 FelixMalfait