twenty
twenty copied to clipboard
twentyhq
Two fixes for dark mode.
1 Color outside the viewport
Current behavior
the body above the content is white in dark mode.
https://github.com/twentyhq/twenty/assets/19412894/c9f434ca-fbe2-4a52-bc88-33363482332f
Desired behavior
It should be background secondary or even better, the noisy background if possible.
https://github.com/twentyhq/twenty/assets/19412894/aa77dad2-3898-4f0a-a3c6-5933342d9e47
2 Default color
Current behavior
The default theme color is light:
Desired behavior
The default theme color should be "System Settings"
Hi @Bonapara I found a way to do the noise change please provide me with the color tone you want for both dark as well as light mode
@charlesBochet should I add this color to background.ts
Hi @Bonapara
Default Color Scheme is "System"
@Kanav-Arora, no because workspaceMember.colorScheme is not empty in DB. I think what @Bonapara means is that, when a workspaceMember is created, it should be associated with "System" color scheme by default
Regarding your other question, I am not sure to get it. what do you mean by noise change?
WorkspaceMember default state is null and as on line in my screenshot System will be assigned so ig when new member is created System is default?
Regarding noise I'm saying that as Thomas specified that colour should be noisy so I was asking which color do I have to use?
Hi @Kanav-Arora, you can find the "noisy" background in the theme (theme.background.noisy).
Hi @thaisguigon The noisy background is same issued in the page whereas the background shown in the issue should be contrasting to the background. Should I go with this only?
@Kanav-Arora I think we want the same, where do you see it different?
In the Github reference video Thomas added in the issue description. There's a contrast with the header so do we want some contrast or same noisy background.
Oh true, that's on the Github video example. Let's do something simple and put the same color!
@Kanav-Arora assigning this issue to you as I see it was discussed. Let us know if you're stuck / how we can help!
Hi @FelixMalfait
Actually If I'm applying constant colors then its working but with noisy image string its not working
Yes I've experimented that a few years ago too I remember. Let's settle for colors. @Bonapara could you please point @Kanav-Arora to the right colors? Thanks a lot
Hi @Kanav-Arora,
We should use Background Tertiary, as it closely matches the noisy background:
Thanks a lot!