Link fields design is incorrect.

Open Bonapara opened this issue 2 years ago • 3 comments

Current behavior

The link field design looks like a regular text field:

Index page:

Screenshot 2023-12-13 at 12 06 06

Show page:

Screenshot 2023-12-13 at 12 12 46

Desired behavior

Put the link in the link field type on both index & show:

Index:

Screenshot 2023-12-13 at 12 07 26

Screenshot 2023-12-13 at 12 04 55

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=14603-76540&mode=design&t=pfE2hTyckvmdvs26-11

Show:

https://github.com/twentyhq/twenty/assets/19412894/c95501ef-6e16-4ec7-bce6-dd326699f47e

Screenshot 2023-12-13 at 12 08 40

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=14603-76540&mode=design&t=pfE2hTyckvmdvs26-11

Dec 13 '23 11:12 Bonapara

Hi @Bonapara I can work on this

Dec 13 '23 17:12 Kanav-Arora

Sure, thanks @Kanav-Arora ;)

Dec 15 '23 10:12 Bonapara

@Bonapara @Kanav-Arora this is not a link field currently, this is a text field. We will actually need to migrate this to a Link field but we are holding as we don't support array fields for now (as we would need to properly implement domain names). What you can do for now @Kanav-Arora is to introduce a DomainFieldInput and DomainFieldDisplay and to conditionnally use it if fieldName = 'domainName' and objectMetadataSingularName = 'company' in FieldDisplay and FieldInput components We do that for phone and email that are not implemented yet either

Long term what we want:

migrate it to link once array fields are supported + we know how to smoothly migrate existing workspaces
treat this as a LinkField with option isDomain

Dec 18 '23 08:12 charlesBochet

Closing because there is now https://github.com/twentyhq/twenty/issues/3607

Jan 25 '24 09:01 FelixMalfait