twenty icon indicating copy to clipboard operation
twenty copied to clipboard

FloatingButton in FloatingButtonGroup should have adaptable borders

Open nimraahmed opened this issue 1 year ago • 14 comments

Bug Description

image

The borders of a FloatingButton inside a FloatingButtonGroup should change depending on its position.

(Note that in the documentation there's a problem because both buttons have the focus and there should only be one. Link to other issue : https://github.com/twentyhq/twenty/issues/3161)

Expected behavior

We need to copy the behavior of a FloatingIconButton in a FloatingIconButtonGroup, see FloatingIconButton.tsx

image

You can see that the button in the middle has different border-radius because its position is middle.

nimraahmed avatar Dec 03 '23 17:12 nimraahmed

Hi @nimraahmed Can I work on this?

Kanav-Arora avatar Dec 03 '23 17:12 Kanav-Arora

@charlesBochet

nimraahmed avatar Dec 04 '23 09:12 nimraahmed

Is anyone working on this ?

BalanaguYashwanth avatar Dec 04 '23 12:12 BalanaguYashwanth

@BalanaguYashwanth Nobody is working on it as far as I know! Please go ahead!

charlesBochet avatar Dec 04 '23 14:12 charlesBochet

See here to check the issue: https://docs.twenty.com/contributor/frontend/ui-components/input/button#floating-button-group

image

charlesBochet avatar Dec 04 '23 14:12 charlesBochet

Got it thanks

BalanaguYashwanth avatar Dec 04 '23 15:12 BalanaguYashwanth

can I take this one?

a-kud avatar Dec 04 '23 20:12 a-kud

You can go head @a-kud

BalanaguYashwanth avatar Dec 05 '23 04:12 BalanaguYashwanth

@charlesBochet is anyone working on this or can i take this up?

nimraahmed avatar Dec 14 '23 18:12 nimraahmed

@nimraahmed Not than I know about! Please go ahead :)

charlesBochet avatar Dec 15 '23 10:12 charlesBochet

I'm still working on it, can finish this week.

a-kud avatar Dec 15 '23 14:12 a-kud

Ok, thank you @a-kud!

@nimraahmed: @a-kud is already working on it :)

charlesBochet avatar Dec 15 '23 14:12 charlesBochet

@a-kud I updated the issue to give you more context, could you please make according changes in your PR ?

lucasbordeau avatar Dec 27 '23 10:12 lucasbordeau

I have a high workload right now, feel free to work on this one.

a-kud avatar Jan 07 '24 00:01 a-kud