twenty
twenty copied to clipboard
FloatingButton in FloatingButtonGroup should have adaptable borders
Bug Description
The borders of a FloatingButton inside a FloatingButtonGroup should change depending on its position.
(Note that in the documentation there's a problem because both buttons have the focus and there should only be one. Link to other issue : https://github.com/twentyhq/twenty/issues/3161)
Expected behavior
We need to copy the behavior of a FloatingIconButton in a FloatingIconButtonGroup, see FloatingIconButton.tsx
You can see that the button in the middle has different border-radius because its position is middle.
Hi @nimraahmed Can I work on this?
@charlesBochet
Is anyone working on this ?
@BalanaguYashwanth Nobody is working on it as far as I know! Please go ahead!
See here to check the issue: https://docs.twenty.com/contributor/frontend/ui-components/input/button#floating-button-group
Got it thanks
can I take this one?
You can go head @a-kud
@charlesBochet is anyone working on this or can i take this up?
@nimraahmed Not than I know about! Please go ahead :)
I'm still working on it, can finish this week.
Ok, thank you @a-kud!
@nimraahmed: @a-kud is already working on it :)
@a-kud I updated the issue to give you more context, could you please make according changes in your PR ?
I have a high workload right now, feel free to work on this one.