twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Design and implement error fallback component

Open lucasbordeau opened this issue 2 years ago • 11 comments

Scope & Context

When a synchronous React error is caught.

Current behavior

We have a very rough error fallback component :

image

Expected behavior

We'd like to have a pretty error fallback component. The retry button allows to reload the page. Use the same style of empty states.

image

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=16596-94606&mode=design&t=paVI9QsoQYc5qsKU-11

lucasbordeau avatar Dec 01 '23 16:12 lucasbordeau

@Bonapara

lucasbordeau avatar Dec 01 '23 16:12 lucasbordeau

@lucasbordeau, description updated

Bonapara avatar Dec 04 '23 12:12 Bonapara

Can you assign this issue to me?

harrisonJones12 avatar Dec 04 '23 19:12 harrisonJones12

How would I pull down this app and start a dev server?

harrisonJones12 avatar Dec 04 '23 21:12 harrisonJones12

@Kanav-Arora could you please handle this as part of https://github.com/twentyhq/twenty/issues/3310 ? I think it'd be nice if we still display the error though - but small font. Thanks 🙏 cc @Bonapara

FelixMalfait avatar Jan 17 '24 11:01 FelixMalfait

Let's put the error under the "Server’s on a coffee break" like this. (With a max width 600px)

image

Bonapara avatar Jan 17 '24 11:01 Bonapara

Hi @FelixMalfait @Bonapara Sure

Kanav-Arora avatar Jan 17 '24 11:01 Kanav-Arora

Thanks @Kanav-Arora!

FelixMalfait avatar Jan 17 '24 12:01 FelixMalfait

Hi @FelixMalfait @Bonapara

I don't think so we should show error message also. What do you think? Its too technical

Screenshot 2024-01-17 at 7 50 04 PM

Kanav-Arora avatar Jan 17 '24 14:01 Kanav-Arora

Thanks @Kanav-Arora I agree it's ugly but it will be handy in the coming months as we are still receiving a lot of bug reports directly from self-hosting users (that we would not see in Sentry). Maybe set a max width on the text so that at least it's a bit more readable and over multiple lines? And eventually also limit the height so that we only see at most 3 lines? What matter is the beginning of the message usually

FelixMalfait avatar Jan 17 '24 14:01 FelixMalfait

The max-width should be 600px indeed!

Bonapara avatar Jan 19 '24 14:01 Bonapara

Hi @FelixMalfait This issue is completed

Kanav-Arora avatar Feb 01 '24 23:02 Kanav-Arora

Great thanks!

FelixMalfait avatar Feb 02 '24 08:02 FelixMalfait