twenty icon indicating copy to clipboard operation
twenty copied to clipboard

New field type: formatted address

Open FelixMalfait opened this issue 1 year ago • 5 comments

Context

We want to create a new field type "formattedAddress" = street + city + country + ... The implementation should be very similar to "fullName" = first name + lastname

Frontend

Edit mode

CleanShot 2023-11-22 at 18 59 49

Link to Figma: figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=15828%3A60465

Edit mode

Concatenate: Street, City, Country If not street then: City, Country If no city then Country

Backend

addressStreet1
addressStreet2
addressCity
addressPostcode
addressState
addressCountry
addressLat
addressLng

Note: lat/long can't be populated for now but we'll soon create a backend a follow-up ticket with Google Maps (or other provider) dropdown that will enable filling this

FelixMalfait avatar Nov 22 '23 18:11 FelixMalfait

Custom address field

Here is also the design for the address field type to create a custom address field in settings.

image

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=15964-91182&mode=design&t=0ARQwG9ztW9zC0Zf-11

Bonapara avatar Nov 22 '23 21:11 Bonapara

@FelixMalfait I would like to work on this issue

lakshay-saini-au8 avatar Dec 14 '23 11:12 lakshay-saini-au8

@lakshay-saini-au8 fyi this is a pretty big task. Happy to assign to you — thanks a lot! Let us know if you need help (you can ask on Discord).

FelixMalfait avatar Dec 14 '23 18:12 FelixMalfait

@FelixMalfait Is anyone else is working on this

lakshay-saini-au8 avatar Dec 31 '23 12:12 lakshay-saini-au8

@lakshay-saini-au8 nobody's working on this no! Sorry I didn't assign it after my message Thanks again!

FelixMalfait avatar Dec 31 '23 13:12 FelixMalfait

I started working on this issue.

capaj avatar Feb 16 '24 13:02 capaj

Thanks @capaj!

FelixMalfait avatar Feb 16 '24 14:02 FelixMalfait

@capaj feel free to reach out on Discord if you need help, backend is fairly complex

FelixMalfait avatar Feb 16 '24 14:02 FelixMalfait

I will not be able to finish this, but if anyone picks it up, feel free to start where I left off using my WIP commit: https://github.com/capaj/twenty/commit/671178352d264d373cd4c11a67e32e0a11d93601

capaj avatar Mar 04 '24 17:03 capaj

@capaj thanks for this already 🙏

FelixMalfait avatar Mar 06 '24 16:03 FelixMalfait

I'm going to start this this weekend 👍🏽

antoniopresto avatar Mar 07 '24 12:03 antoniopresto

Thanks @antoniopresto!

Bonapara avatar Mar 07 '24 12:03 Bonapara

@antoniopresto fyi we're going to re-organize the folder structure this week-end so if you want to re-use @capaj's work and avoid conflicts, maybe you could raise a v1 PR (e.g. no frontend just backend / with feature flag on the object) and then raise a v2 later during the week

FelixMalfait avatar Mar 07 '24 15:03 FelixMalfait

Im sorry, I ended having no time to work on this

antoniopresto avatar Mar 11 '24 04:03 antoniopresto

Id like to tackle this one :) Dont worry @antoniopresto your work wont come wasted. Ill try to reuse your WIP branch.

rostaklein avatar Mar 14 '24 20:03 rostaklein

Thanks @rostaklein, just assigned you!

Bonapara avatar Mar 15 '24 08:03 Bonapara