Silent error on metadata object create if name contains forbidden characters

[lucasbordeau]

Bug Description

When we create a metadata object with createOneObject on /metadata, if we pass a nameSingular or namePlural with : . for example, it will crash or produce a name different than the user input (for example with just the right part of the string split with .)

Expected behavior

We want to receive an error on the frontend if the user sends forbidden characters in nameSingular or namePlural, we should also prevent the user from sending forbidden characters by using a regex in the text input and a message that explains why we cannot input forbidden characters.

[charlesBochet]

@magrinj input: use classValidator on entities

[FelixMalfait]

I was thinking we should do something like ^[A-Za-z0-9 ]*$ but not cool for people using non-latin characters, could be better to use a blacklist instead of a whitelist.

I propose the following regex: ^[^'\"\\;./*=*/]+$

Possible steps to resolve:

• Frontend: modify frontend inputs on SettingsObjectFormSection to something like <input type="text" pattern="^[^'\"\\;./*=*/]+$" />
• Backend: use https://www.npmjs.com/package/class-validator -> @Matches() on object metadata dtos (see field meta data dtos)

[a-kud]

Is this up for grabs?

[FelixMalfait]

Sure @a-kud thanks a lot!

[a-kud]

I have a high workload right now, feel free to work on this one.

[FelixMalfait]

No prob, thanks @a-kud