twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Published 20 hours ago • verified publisher icon twentyhq

feat: Board options edit and reorder

Open AdityaPimpalkar opened this issue 2 years ago • 6 comments

closes: #818

Tasks

  1. Rendering pipeline stages in options
  2. Waiting for #1738 to get merged to add DraggableList on Fields and Stages
  3. Separating onDragEnd logic to avoid duplicated logic
  4. Adding visible/hidden board column states
  5. Adding isVisible column to pipeline_stages on the backend
  6. Creating a new component MenuItemTag which renders Tag inside MenuItem
  7. Render BoardColumnEditTitleMenu on edit

AdityaPimpalkar avatar Oct 03 '23 22:10 AdityaPimpalkar

@AdityaPimpalkar the other PR has been merged! Thanks for all your contributions!

charlesBochet avatar Oct 04 '23 15:10 charlesBochet

A few issues I am running into:

  • [x] css is being a little weird after adding the DraggableList component
  • [x] isVisible property Is not updating on the backend
  • [ ] Edit title component height is overflowing from the screen (maybe we can come up with some other design)

https://github.com/twentyhq/twenty/assets/13139771/7c887504-4e63-48dd-baf3-77822817f3ea

AdityaPimpalkar avatar Oct 08 '23 20:10 AdityaPimpalkar

@AdityaPimpalkar @bosiraphael I've tried to merge it but we are too far now. I'm leaving it open. We will pick and re-use the components once the Board refactoring is completed

charlesBochet avatar Nov 09 '23 17:11 charlesBochet

@AdityaPimpalkar We have not forgotten this one! We are getting there, it's likely to be tackled early next week!

charlesBochet avatar Jan 03 '24 22:01 charlesBochet

Hey @charlesBochet I can re implement this in a new PR if you want, you can close this one because there are too many conflicts

AdityaPimpalkar avatar Jan 04 '24 05:01 AdityaPimpalkar

Thank you @AdityaPimpalkar I'll likely ping you next week then!

charlesBochet avatar Jan 05 '24 10:01 charlesBochet

@AdityaPimpalkar, we have changed our product requirement on this one. In the new board implementation, you'll be able to create a board on any object having a field of type SELECT. The existing board is a board of Opportunity on field Stage. Re-ordering and changing the column will be done through Settings > Data model. We don't want to make them editable on the board directly anymore as this would confuse the users to be able to edit opportunity stages in two different places.

Thanks again for the multiple contributions on Twenty!

charlesBochet avatar Feb 05 '24 14:02 charlesBochet