twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Implement an example test for hotkeys on dropdown

Open lucasbordeau opened this issue 1 year ago • 5 comments

Current behavior Currently we have no extensive testing on the potential hotkey scope conflicts that may arise on components like dropdowns or right drawers

Expected behavior We need to create at least one first test as an example.

In storybook a good place to have those tests would be on complete pages (ex: Company.stories.tsx) so everything is loaded and we can create fake conflicts for testing.

Additional context Be careful with storybook as it can be tedious to work with keyboard shortcuts, you may find examples like userEvent.type(searchInput, '{arrowdown}'); in the code by searching.

lucasbordeau avatar Sep 15 '23 08:09 lucasbordeau

Hello @lucasbordeau, i can do this? Put me as Assignees.

lucasfirmo62 avatar Oct 19 '23 19:10 lucasfirmo62

Hi @lucasfirmo62, sorry for the delay, you're welcome to work on this issue, please don't hesitate to join our Discord to discuss the details.

lucasbordeau avatar Oct 30 '23 12:10 lucasbordeau

https://discord.gg/bNgBwJny

lucasbordeau avatar Oct 30 '23 12:10 lucasbordeau

Is it still relevant @lucasbordeau? If yes, is it something we should do in the next 6 months? Otherwise I will switch it as a discussion ;)

Bonapara avatar Jan 26 '24 15:01 Bonapara

@Bonapara This is nice to have and shouldn't be prioritized.

lucasbordeau avatar Jan 30 '24 10:01 lucasbordeau