rules_nixpkgs icon indicating copy to clipboard operation
rules_nixpkgs copied to clipboard

Add nodejs toolchain

Open betaboon opened this issue 3 years ago • 8 comments

betaboon avatar Apr 22 '22 13:04 betaboon

I'm still working on this.

currently i'm stuck at it running into mismatching values: support_nix. i bet there is just a minor thing missing somewhere. maybe someone has a clue. i would be greatful for any hints ;)

betaboon avatar Apr 22 '22 16:04 betaboon

thanks to @chancila i figured out that only a setting in .bazelrc was missing: build:nix --extra_execution_platforms=@io_tweag_rules_nixpkgs//nixpkgs/platforms:host

betaboon avatar Apr 23 '22 18:04 betaboon

Hi @betaboon , thank you for your contribution!

Are you still working on it or do you need some assistance?

avdv avatar May 02 '22 11:05 avdv

@avdv I'm still working on this. planning to get the documentation ready in the next couple days.

i could need some assistance on the issue of the required --extra_execution_platforms, if that is something that we would want.

if there are any other pointers to get this in a ready state I'd gladly integrate them

betaboon avatar May 02 '22 11:05 betaboon

Hi @betaboon , sorry for the long delay.

I had a look at this again. Also, I rebased onto master and added a missing dependency.

An example for the toolchain would be nice to have.

Thank you!

avdv avatar Jun 01 '22 13:06 avdv

@avdv sorry for the long silence.

i just rebased against master, included your changes, updated the nodejs and nixpkgs rules, added an example.

i think this is now fine and ready :)

betaboon avatar Aug 08 '22 14:08 betaboon

Oh, I missed this update over the course of my holidays... I'm taking a look now.

avdv avatar Sep 16 '22 08:09 avdv

i just rebased against master

betaboon avatar Sep 16 '22 12:09 betaboon

Thank you, again! @betaboon

avdv avatar Oct 06 '22 09:10 avdv