rules_nixpkgs icon indicating copy to clipboard operation
rules_nixpkgs copied to clipboard

cc: Remove explicit CXX_FLAG

Open dmadisetti opened this issue 3 years ago • 1 comments

Ran workflows on my branch and it seemed to work (except the hooks that need buildbuddy) https://github.com/AnotherGroupChat/rules_nixpkgs/actions/runs/2157830144

Just seeing how #218 influences your tests. Let me know if there is a better way- but vanilla bazel does not add this flag

Opening as a draft as you all may have better ideas on how to implement this

dmadisetti avatar Apr 12 '22 22:04 dmadisetti

See https://github.com/tweag/rules_nixpkgs/issues/218#issuecomment-1097644432 for why -x c++ was added.

aherrmann avatar Apr 13 '22 07:04 aherrmann

@dmadisetti is this still something you need? It seems like the upstream fix at https://github.com/bazelbuild/bazel/issues/15499 is also stalled.

evertedsphere avatar Dec 22 '22 13:12 evertedsphere

See #298.

evertedsphere avatar Dec 22 '22 13:12 evertedsphere

Done in #298.

evertedsphere avatar Jan 09 '23 14:01 evertedsphere