jupyenv icon indicating copy to clipboard operation
jupyenv copied to clipboard

Refactor jupyenv

Open GTrunSec opened this issue 2 years ago • 7 comments

fixes: #485 #484 #497 #525 #482 #477 #478 #479 #388 #371 #328 #284 #527

GTrunSec avatar Oct 01 '23 08:10 GTrunSec

Deploy Preview for tweag-jupyterwith ready!

Name Link
Latest commit 38ee7c1192a3771b88796fc3022a5b4f12a26418
Latest deploy log https://app.netlify.com/sites/tweag-jupyterwith/deploys/65c3fbc9464d210008adba0f
Deploy Preview https://deploy-preview-524--tweag-jupyterwith.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 01 '23 08:10 netlify[bot]

@balsoft refactor-stage1 has been DONE.

GTrunSec avatar Oct 02 '23 06:10 GTrunSec

I've tried to set extraHaskellPackages = p: [ p.bytestring p.text ] for the haskell kernel but if fails because those are null in nixpkgs and the option expects a function towards a list of packages

        extraHaskellPackages = lib.mkOption {
          type = types.functionTo (types.listOf types.package);
          default = _: [];

I think it would be less surprising to have

        extraHaskellPackages = lib.mkOption {
          type = types.functionTo (types.listOf (types.nullOr types.package));
          default = _: [];

teto avatar Nov 03 '23 13:11 teto

@teto Thanks, fixed

GTrunSec avatar Nov 04 '23 06:11 GTrunSec

@GTrunSec , just wondering what work needs to be wrapped up here to push these changes. Is it just the failing haskell test that is blocking? I would love to help!

aniinbkln avatar Jul 23 '24 01:07 aniinbkln

@aniinbkln the building of Haskell is ok, just no maintainer(with the PR permission) in this project.

GTrunSec avatar Jul 24 '24 01:07 GTrunSec

mac m1 user awaiting fix ;)

cschar avatar Aug 26 '24 16:08 cschar