jupyenv
jupyenv copied to clipboard
fix: wrap jupyter-notebook binary too
some environments like ihaskell don't work well with jupyterLab (only in jupyter-notebook) but jupyter-notebook is not wrapped.
I found this useful. Also to wrap jupyter_client
, which provides the jupyter-kernelspec
command (used by e.g. emacs-jupyter).
Should this also use buildEnv
or similar to make jupyter-notebook
available in the environment? For my use case (trying to get emacs-jupyter working) I ended up with https://github.com/mcwitt/jupyterWith/commit/5a2e1e615010c88cebca9a694eb58de17ee0cd41.
Tests are not passing for the Flake, can you take a look?
Also, what is the nature of the repo forJupyter
you added to it?
I didn't realize this was my PR branch. Will rebase once https://github.com/tweag/jupyterWith/pull/173 gets merged.
CI fails for mac with AttributeError: dlsym(RTLD_DEFAULT, GetMacOSStatusCommentString): symbol not found
. Not sure how to solve that.
I rebased the PR.
This is the corresponding Jupyter issue: https://github.com/jupyterlab/jupyterlab/issues/9863
thanks. As usual, macos is the culprit but I dont know how to fix those. It looks similar to a previous issue as the stacktrace mentions send2trash.
Closing since this is already fixed in next
branch.
@garbas do you mean "main" ? can't find a next branch (from github UI)