jupyenv icon indicating copy to clipboard operation
jupyenv copied to clipboard

fix: wrap jupyter-notebook binary too

Open teto opened this issue 4 years ago • 6 comments

some environments like ihaskell don't work well with jupyterLab (only in jupyter-notebook) but jupyter-notebook is not wrapped.

teto avatar Feb 04 '21 13:02 teto

I found this useful. Also to wrap jupyter_client, which provides the jupyter-kernelspec command (used by e.g. emacs-jupyter).

Should this also use buildEnv or similar to make jupyter-notebook available in the environment? For my use case (trying to get emacs-jupyter working) I ended up with https://github.com/mcwitt/jupyterWith/commit/5a2e1e615010c88cebca9a694eb58de17ee0cd41.

mcwitt avatar Jul 04 '21 18:07 mcwitt

Tests are not passing for the Flake, can you take a look?

Also, what is the nature of the repo forJupyter you added to it?

guaraqe avatar Oct 14 '21 20:10 guaraqe

I didn't realize this was my PR branch. Will rebase once https://github.com/tweag/jupyterWith/pull/173 gets merged.

teto avatar Oct 25 '21 16:10 teto

CI fails for mac with AttributeError: dlsym(RTLD_DEFAULT, GetMacOSStatusCommentString): symbol not found . Not sure how to solve that.

teto avatar Jan 07 '22 14:01 teto

I rebased the PR.

This is the corresponding Jupyter issue: https://github.com/jupyterlab/jupyterlab/issues/9863

guaraqe avatar Feb 08 '22 19:02 guaraqe

thanks. As usual, macos is the culprit but I dont know how to fix those. It looks similar to a previous issue as the stacktrace mentions send2trash.

teto avatar Mar 06 '22 00:03 teto

Closing since this is already fixed in next branch.

garbas avatar Aug 17 '22 19:08 garbas

@garbas do you mean "main" ? can't find a next branch (from github UI)

teto avatar Aug 17 '22 22:08 teto