ratchet icon indicating copy to clipboard operation
ratchet copied to clipboard

New "side-menus" component.

Open mrienstra opened this issue 10 years ago • 15 comments

Based on the modals component.

See example at http://michaelrienstra.com/temporary/ratchet/side-menus.html

The current implementation relies on putting a wrapper (<div class="side-menu-siblings-wrapper">) around the side-menus siblings (<header class="bar"> & <div class="content">).

Alternatives: I have working code to handle the wrapping of siblings automatically, as well as mostly working code sans wrapper (abandoned when I realized it would take more "moving bits" to get the subtle drop shadow to animate, and the wrapper approach started to look cleaner).

Minimally tested on Android (Nexus 4) & iOS (iPhone 5).

Happy to do more testing / etc. if this component is of interest.

Attribution: I borrowed a few lines of CSS from http://mmenu.frebsite.nl/ (which is dual licensed under the MIT and GPL licenses).

mrienstra avatar Apr 11 '14 01:04 mrienstra

Great!

aceport avatar Apr 11 '14 03:04 aceport

Alternate solution: https://github.com/jakiestfu/Snap.js/

mrienstra avatar Apr 11 '14 18:04 mrienstra

@mrienstra On Android 4.0.4 title bar doesn't move and obstructs first menu item. Also after opening there's a gap after menu, see attached screenshot. screenshot_2014-04-12-13-01-21

joshas avatar Apr 12 '14 10:04 joshas

@joshas Thanks for the heads up. Changing .bar from position: fixed to position: absolute seems to help with the title bar problem. Demo 3

Looks like Dolphin 10.3.1 (Nexus 4 running Android 4.4.2) has some problems with the animation (overshoots, then snaps back).

Haven't been able to reproduce the gap problem -- my emulator keeps crashing when I try to run 4.0 or 4.0.4. Let me know if you're in the mood to triage. :)

mrienstra avatar Apr 13 '14 00:04 mrienstra

This appears to break the modals component if they are both used on the same page. I implemented this into the "app-ios-mail" example. Even after moving the compose to a new page it appears there is some issue where it does not fire.

emisicka avatar May 20 '14 21:05 emisicka

@emisicka: I'll take a look at that when I have time. Can you put your code somewhere I can access it?

mrienstra avatar May 20 '14 21:05 mrienstra

@mrienstra Cool. I changed up the content with examples to recreate what I was experiencing. http://misicka.com/ratchet/

emisicka avatar May 20 '14 21:05 emisicka

Thank you, @mrienstra!

ramilexe avatar Jun 16 '14 23:06 ramilexe

@mrienstra why scroll doesn't work in menu bar?

ramilexe avatar Jun 16 '14 23:06 ramilexe

/CC @twbs/ratchet

XhmikosR avatar Feb 09 '15 04:02 XhmikosR

what's up? why pr still open?

milushov avatar Nov 01 '15 04:11 milushov

^bump. Was debugging for a while trying to figure out why the example is working and my code is not with the same version number when I realized the PR is still open and not merged... could be nice to merge it just so Ratchet has this functionality.

tomershvueli avatar Nov 28 '16 16:11 tomershvueli

Is there a more reliable fork of this project this could be merged into?

trumb1mj avatar Nov 28 '16 16:11 trumb1mj

Not that I'm aware of, I'm new here... :)

tomershvueli avatar Nov 28 '16 16:11 tomershvueli

Great :)))) 👍

But can you add more features for menu like :: ability to drag , ability to control width of menu, make menu overlay the page not pushing the body ..

Toomavic avatar Nov 29 '16 04:11 Toomavic