examples icon indicating copy to clipboard operation
examples copied to clipboard

Deprecation warnings on webpack example

Open Int-Circuit opened this issue 1 year ago • 4 comments

when running webpack example, I get these deprecation warnings:

WARNING in ./src/scss/styles.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[0].use[2]!./node_modules/sass-loader/dist/cjs.js!./src/scss/styles.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 37, column 4 of file:///home/mathis/Documents/Git/secrets/browser-ext/node_modules/bootstrap/scss/_type.scss:37:4:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

37 |     font-family: $display-font-family;


node_modules/bootstrap/scss/_type.scss 38:5      @import
node_modules/bootstrap/scss/bootstrap.scss 17:9  @import
src/scss/styles.scss 2:9                         root stylesheet
WARNING in ./src/scss/styles.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[0].use[2]!./node_modules/sass-loader/dist/cjs.js!./src/scss/styles.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 38, column 4 of file:///home/mathis/Documents/Git/secrets/browser-ext/node_modules/bootstrap/scss/_type.scss:38:4:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

38 |     font-style: $display-font-style;


node_modules/bootstrap/scss/_type.scss 39:5      @import
node_modules/bootstrap/scss/bootstrap.scss 17:9  @import
src/scss/styles.scss 2:9                         root stylesheet
WARNING in ./src/scss/styles.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[0].use[2]!./node_modules/sass-loader/dist/cjs.js!./src/scss/styles.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 39, column 4 of file:///home/mathis/Documents/Git/secrets/browser-ext/node_modules/bootstrap/scss/_type.scss:39:4:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

39 |     font-weight: $display-font-weight;


node_modules/bootstrap/scss/_type.scss 40:5      @import
node_modules/bootstrap/scss/bootstrap.scss 17:9  @import
src/scss/styles.scss 2:9                         root stylesheet
WARNING in ./src/scss/styles.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[0].use[2]!./node_modules/sass-loader/dist/cjs.js!./src/scss/styles.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 502, column 2 of file:///home/mathis/Documents/Git/secrets/browser-ext/node_modules/bootstrap/scss/_reboot.scss:502:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

502 |   font-weight: $legend-font-weight;


node_modules/bootstrap/scss/_reboot.scss 503:3   @import
node_modules/bootstrap/scss/bootstrap.scss 16:9  @import
src/scss/styles.scss 2:9                         root stylesheet
WARNING in ./src/scss/styles.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[0].use[2]!./node_modules/sass-loader/dist/cjs.js!./src/scss/styles.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 503, column 2 of file:///home/mathis/Documents/Git/secrets/browser-ext/node_modules/bootstrap/scss/_reboot.scss:503:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

503 |   line-height: inherit;


node_modules/bootstrap/scss/_reboot.scss 504:3   @import
node_modules/bootstrap/scss/bootstrap.scss 16:9  @import
src/scss/styles.scss 2:9                         root stylesheet
WARNING in ./src/scss/styles.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[0].use[2]!./node_modules/sass-loader/dist/cjs.js!./src/scss/styles.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
22 repetitive deprecation warnings omitted.
Run in verbose mode to see all warnings.

Int-Circuit avatar Sep 05 '24 13:09 Int-Circuit

Hey @Int-Circuit It's linked to https://github.com/twbs/bootstrap/issues/40621 that will be fixed in Bootstrap v5.3.4. In the meantime, in this webpack project, you can force the sass dependency (in the package.json) to use the 1.77.6 instead of 1.77.8 :)

https://github.com/twbs/examples/blob/3f25983b86791f111984d4c6235b971f50fe1927/webpack/package.json#L25

julien-deramond avatar Sep 05 '24 13:09 julien-deramond

Lots of deprecation warnings in 1.77.6 also :(

alexbogias avatar Oct 31 '24 11:10 alexbogias

Hey @Int-Circuit It's linked to twbs/bootstrap#40621 that will be fixed in Bootstrap v5.3.4. In the meantime, in this webpack project, you can force the sass dependency (in the package.json) to use the 1.77.6 instead of 1.77.8 :)

https://github.com/twbs/examples/blob/3f25983b86791f111984d4c6235b971f50fe1927/webpack/package.json#L25

same issue still exists. disappointing

RabbiIslamRony avatar Nov 05 '24 13:11 RabbiIslamRony

@RabbiIslamRony When do you think 5.3.4 will come out?

danon avatar Jan 03 '25 12:01 danon

v5.3.4 and v5.3.5 have shipped. We'll take another look through the dependencies to ensure everything's up to par.

mdo avatar Apr 08 '25 19:04 mdo

Fixed by https://github.com/twbs/examples/commit/2393bf3ebfcb8c906759a8fb7c3ee346e938d9b1

julien-deramond avatar Jun 01 '25 09:06 julien-deramond