Remove `outline: 0` from modals

[coliff]

Description

This was added about 12 years ago and is no longer needed from what I can tell.

I've tested with Chrome 133 and Edge 122 on Windows 11. The modal itself is never focused anyway, when the modal opens the focus is only within the modal.

Motivation & Context

No longer needed. Removing it saves a few bytes. :-)

Type of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Refactoring (non-breaking change)
• [ ] Breaking change (fix or feature that would change existing functionality)

Checklist

• [x] I have read the contributing guidelines
• [ ] My code follows the code style of the project (using npm run lint)
• [ ] My change introduces changes to the documentation
• [ ] I have updated the documentation accordingly
• [ ] I have added tests to cover my changes
• [ ] All new and existing tests passed

Live previews

• https://deploy-preview-41269--twbs-bootstrap.netlify.app/docs/5.3/components/modal/

Related issues

[julien-deramond]

Thanks for this patch. Unfortunately, I don't have access anymore to BrowserStack (or any equivalent tool) to try to render the thing with Chrome 60 on Windows (based on the rules of our current .browserslistrc. The safest option would maybe be to merge this PR in v6 where we'll use less restrictive rules in the .browserslistrc file.

[coliff]

thanks! I have a BrowserStack subscription and just tested this with Chrome 60 on Windows 10 and it does indeed still have an unwanted blue outline without the outline: 0

Production version (with the outline: 0) doesn't have this issue:

So you're quite right, it should be parked until v6. 👍

[julien-deramond]

Thanks a lot for providing the rendering with Chrome 60 on Windows 10 🙌 @mdo That's something you could introduce in your current work in the v6-dev branch.

[mdo]

Man, Chrome 60 is archaic these days lol. I can't wait to move on from our browser support list here. Let's just save for v6 to be good about leaving v5 in a good spot for what it is. We can always roll back on this. But at the same time, I don't care at all haha.