bootstrap icon indicating copy to clipboard operation
bootstrap copied to clipboard

docs(list-group): Remove disabled for readonly example and fix SR for disabled link

Open MarkoOleksiyenko opened this issue 11 months ago • 2 comments

Description

Moving the Disabled section into Links and Buttons and fixing the SR for disabled link example

Motivation & Context

List-group non-interactive examples should not be disabled and are ignored by the assistive technology.

I propose to move the Disabled section into the Links and buttons with a precision on how to disable it.

In addition to that the Disabled Link example has to include the href="#" for the SR to properly announce that it is unavailable.

Type of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Refactoring (non-breaking change)
  • [ ] Breaking change (fix or feature that would change existing functionality)

Checklist

  • [x] I have read the contributing guidelines
  • [x] My code follows the code style of the project (using npm run lint)
  • [x] My change introduces changes to the documentation
  • [x] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [x] All new and existing tests passed

Live previews

Related issues

https://github.com/twbs/bootstrap/issues/40752

MarkoOleksiyenko avatar Jan 07 '25 12:01 MarkoOleksiyenko

Hello @julien-deramond , I am working on the accessibility in my project and noticed that with list-group there is an issue with SR while reading the disabled link + the disabled on readonly doesn't make sense (saw that it is mentioned in the https://github.com/twbs/bootstrap/issues/40752).

I wonder what do you think about a small rearrangement with disabled state ?

We can also add the note that with disabled attribute you can omit the aria-disabled="true" for elements like buttons.

MarkoOleksiyenko avatar Jan 07 '25 12:01 MarkoOleksiyenko

@julien-deramond I think this makes sense, I'm fine to consolidate the docs here. Also /cc @patrickhlauke for quick eyes.

mdo avatar Apr 11 '25 17:04 mdo