bootstrap icon indicating copy to clipboard operation
bootstrap copied to clipboard

Edit navbar-nav dropdown-menu appearance on condensed navbars

Open antoinevilain001 opened this issue 1 year ago • 1 comments

Description

Currently the expanded navbar with a dropdown menu looks like this: image And the condensed navbar with a dropdown menu looks like this: image The proposed fix would make the condensed dropdown menu always pop out as with the expanded navbar, like so: image

Motivation & Context

This is purely a cosmetic change, The intention is to make the navbar look better as the current version does not look so nice.

Type of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Refactoring (non-breaking change)
  • [x] Breaking change (fix or feature that would change existing functionality)

Checklist

  • [x] I have read the contributing guidelines
  • [x] My code follows the code style of the project (using npm run lint)
  • [ ] My change introduces changes to the documentation
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] All new and existing tests passed

npm test currently failing with the below signature but I don't believe this is due to my changes as it occurs when I run on an unchanged main branch as well. I will open a new issue about this. Running vnu-jar validation... command used: java -jar "C:...my_path...\bootstrap\node_modules\vnu-jar\build\dist\vnu.jar" --asciiquotes --skip-non-html --Werror --filterpattern "Attribute “autocomplete” is only allowed when the input type is.*|Attribute “autocomplete” not allowed on element “button” at this point.|An “aria-disabled” attribute whose value is “true” should not be specified on an “a” element that has an “href” attribute." _site/ js/tests/

Live previews

https://deploy-preview-41080--twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#offcanvas

Related issues

Addresses #41049

antoinevilain001 avatar Dec 06 '24 21:12 antoinevilain001

I'm down to revisit this—I've never liked the implementation we have.

mdo avatar Apr 09 '25 05:04 mdo