bootstrap icon indicating copy to clipboard operation
bootstrap copied to clipboard

Remove unreferenced CSS variable in `bootstrap-reboot*.css`

Open mon-jai opened this issue 2 years ago • 6 comments

Prerequisites

Proposal

The following CSS variables are not referenced in bootstrap-reboot*.css but are included in compiled assets.

They doubled the download size (6187 out of 12065 characters are CSS variables) with no real benefits. Maybe consider removing them in v6?

--bs-blue
--bs-indigo
--bs-purple
--bs-pink
--bs-red
--bs-orange
--bs-yellow
--bs-green
--bs-teal
--bs-cyan
--bs-black
--bs-white
--bs-gray
--bs-gray-dark
--bs-gray-100
--bs-gray-200
--bs-gray-300
--bs-gray-400
--bs-gray-500
--bs-gray-600
--bs-gray-700
--bs-gray-800
--bs-gray-900
--bs-primary
--bs-secondary
--bs-success
--bs-info
--bs-warning
--bs-danger
--bs-light
--bs-dark
--bs-primary-rgb
--bs-secondary-rgb
--bs-success-rgb
--bs-info-rgb
--bs-warning-rgb
--bs-danger-rgb
--bs-light-rgb
--bs-dark-rgb
--bs-primary-text-emphasis
--bs-secondary-text-emphasis
--bs-success-text-emphasis
--bs-info-text-emphasis
--bs-warning-text-emphasis
--bs-danger-text-emphasis
--bs-light-text-emphasis
--bs-dark-text-emphasis
--bs-primary-bg-subtle
--bs-secondary-bg-subtle
--bs-success-bg-subtle
--bs-info-bg-subtle
--bs-warning-bg-subtle
--bs-danger-bg-subtle
--bs-light-bg-subtle
--bs-dark-bg-subtle
--bs-primary-border-subtle
--bs-secondary-border-subtle
--bs-success-border-subtle
--bs-info-border-subtle
--bs-warning-border-subtle
--bs-danger-border-subtle
--bs-light-border-subtle
--bs-dark-border-subtle
--bs-white-rgb
--bs-black-rgb
--bs-font-sans-serif
--bs-gradient
--bs-body-color-rgb
--bs-body-bg-rgb
--bs-emphasis-color
--bs-emphasis-color-rgb
--bs-secondary-color-rgb
--bs-secondary-bg
--bs-secondary-bg-rgb
--bs-tertiary-color
--bs-tertiary-color-rgb
--bs-tertiary-bg
--bs-tertiary-bg-rgb
--bs-link-color
--bs-link-decoration
--bs-link-hover-color
--bs-border-style
--bs-border-color
--bs-border-color-translucent
--bs-border-radius
--bs-border-radius-sm
--bs-border-radius-lg
--bs-border-radius-xl
--bs-border-radius-xxl
--bs-border-radius-2xl
--bs-border-radius-pill
--bs-box-shadow
--bs-box-shadow-sm
--bs-box-shadow-lg
--bs-box-shadow-inset
--bs-focus-ring-width
--bs-focus-ring-opacity
--bs-focus-ring-color
--bs-form-valid-color
--bs-form-valid-border-color
--bs-form-invalid-color
--bs-form-invalid-border-color

Motivation and context

Reduce download/bundle size.

mon-jai avatar Dec 26 '23 16:12 mon-jai

@mon-jai Can this issue be assigned to me? I'll try my best

manviyadu1shi avatar Jan 09 '24 11:01 manviyadu1shi

I am not a maintainer of this project. You should ask @julien-deramond instead.

mon-jai avatar Jan 09 '24 17:01 mon-jai

I am not a maintainer of this project. You should ask @julien-deramond instead.

Oh! Thanks for letting me know.

manviyadu1shi avatar Jan 10 '24 14:01 manviyadu1shi

@julien-deramond can this issue be asssigned to me?

manviyadu1shi avatar Jan 10 '24 14:01 manviyadu1shi

@julien-deramond can this issue be asssigned to me?

Hi @manviyadu1shi I'm off for a few weeks so sorry for the quick answer. As mentioned in our contributing guidelines we don't assign issues. Moreover, this one is labeled as v6 so it can't be started now as the v6 dev hasn't started yet.

julien-deramond avatar Jan 10 '24 15:01 julien-deramond

@julien-deramond can this issue be asssigned to me?

Hi @manviyadu1shi I'm off for a few weeks so sorry for the quick answer. As mentioned in our contributing guidelines we don't assign issues. Moreover, this one is labeled as v6 so it can't be started now as the v6 dev hasn't started yet.

Oh! Sorry , I should have read the contributing guidelines first. Got it. Thanks!

manviyadu1shi avatar Jan 10 '24 15:01 manviyadu1shi