bootstrap icon indicating copy to clipboard operation
bootstrap copied to clipboard

CSS: Make use of `--bs-link-decoration` and `--bs-link-hover-decoration`

Open louismaximepiton opened this issue 1 year ago • 6 comments

Description

Make use of --bs-link-decoration and --bs-link-hover-decoration in Bootstrap.

Motivation & Context

More flexible for Bootstrap users.

Type of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Refactoring (non-breaking change)
  • [ ] Breaking change (fix or feature that would change existing functionality)

Checklist

  • [x] I have read the contributing guidelines
  • [x] My code follows the code style of the project (using npm run lint)
  • [x] My change introduces changes to the documentation
  • [x] I have updated the documentation accordingly
  • [x] I have added tests to cover my changes
  • [x] All new and existing tests passed

Live previews

Related issues

Closes #36293.

louismaximepiton avatar Aug 23 '23 12:08 louismaximepiton

Tagged it as v5.4.0 since it's a new feature non-related to color modes fixes.

julien-deramond avatar Sep 13 '23 07:09 julien-deramond

Is it really a new feature? Since the variable was there before, but it was just not used anywhere, so I would say it's more a bug fix.

AgentSmith0 avatar Sep 13 '23 12:09 AgentSmith0

Fingers are often pointed at us because regarding how we sometimes handle the SemVer. TBH, it's a bit difficult to evaluate what should be in a major, minor, or dot release depending on how advanced is the usage (basic, Sass customization, custom properties advanced usage, etc.). Regarding this PR I have mixed feelings regarding the fact it's rather a bug fix or a "new feature" (at least an enhancement). Let it for now for a v5.4.0 waiting for @twbs/css-review thoughts. Depending on these thoughts, I can prioritize it for the next v5.3.3 to release it sooner.

julien-deramond avatar Sep 13 '23 12:09 julien-deramond

Thank you @louismaximepiton. This is just what I was looking for!

jcoyne avatar Dec 08 '23 14:12 jcoyne

Is there a new feature release planned soon?

AgentSmith0 avatar Feb 02 '24 22:02 AgentSmith0

Is there a new feature release planned soon?

It's not planned yet. Release v5.3.3 is soon to be released and we still need to define if there will be a v5.3.4 before the v5.4.0.

julien-deramond avatar Feb 03 '24 06:02 julien-deramond