bootstrap icon indicating copy to clipboard operation
bootstrap copied to clipboard

Fix a race condition between _queueCallback and dispose.

Open michaelglas opened this issue 2 years ago • 2 comments

if _queueCallback is called just before dispose the transition complete callback will be called on the disposed component and almost certainly error out.

This can happen if a tooltip is removed just as it gets hidden.

michaelglas avatar Mar 29 '22 10:03 michaelglas

@michaelglas Thank you for your contribution. Please support it adding some tests. (Preferable on baseComponent )

GeoSot avatar Mar 31 '22 09:03 GeoSot

Done

michaelglas avatar Apr 04 '22 07:04 michaelglas

@GeoSot Are we willing to merge this if conflicts are resolved?

charlesfries avatar May 22 '23 19:05 charlesfries

@GeoSot Are we willing to merge this if conflicts are resolved?

@XhmikosR @julien-deramond any opinions on this?

It is not the best, but it is a fine defensive approach to solve clumsy implementations

GeoSot avatar May 24 '23 08:05 GeoSot

This issue gives so much headache. We should be able to use dispose without having to worry about tooltips or modals being in show/hide transition.

CatchABus avatar Sep 22 '23 16:09 CatchABus