bootstrap-npm-starter Update start.scss to conform to bootstrap 5.1 instructions

Update start.scss to conform to bootstrap 5.1 instructions

Open djKianoosh opened this issue 3 years ago • 4 comments

Following the instructions here: https://getbootstrap.com/docs/5.1/customize/sass/#variable-defaults

Moved the functions import first, to avoid $theme-colors "isn't a valid CSS value" https://stackoverflow.com/q/68909199/573389

Aug 30 '21 15:08 djKianoosh

Thanks but this will be fixed in #49

Aug 31 '21 18:08 XhmikosR

Cool that's good to know. That's why I targeted the v5 branch.

Aug 31 '21 19:08 djKianoosh

Actually, wait. If this is targeting the v5 branch it might still be valid. /CC @mdo

Sep 01 '21 05:09 XhmikosR

The key line from the docs is

Variable overrides must come after our functions are imported, but before the rest of the imports.

which I also added in a comment so it's not missed. That seems to be the difference.

Sep 01 '21 13:09 djKianoosh