bootstrap-npm-starter icon indicating copy to clipboard operation
bootstrap-npm-starter copied to clipboard

Published 20 hours ago • verified publisher icon twbs

Upgrade to Bootstrap 5

Open mdo opened this issue 3 years ago • 6 comments

  • Updates dependencies as needed, dropping jQuery and moving to Popper 2
  • Updates the Bootstrap import stack
  • Moves from modal in example to offcanvas, with a custom CSS adjustment
  • Updates JS includes to use offcanvas and dropdown for new demo, including some quick guidance on including necessary DOM scripts (this is probably wrong, but it works)
  • Reflect changes in the readme

TODO:

  • [x] Fix offcanvas backdrop missing
  • [ ] ~~Switch to our bundle JS file and remove popper and custom imports?~~ @mdo: No, I'd like to keep the specific options
  • [ ] Move postcss config to postcss.config.js?

mdo avatar May 06 '21 06:05 mdo

@mdo great that v5 finally released, so one more step is here :) I see node-sass removed, as @bardware mentioned in #35 - now it will be good, it must be good.

@mdo will u have time to finalize this PR?

cc/ @HansUXdev

alundiak avatar May 14 '21 07:05 alundiak

Left some comments, I'll try to have a look and fix some of the things later myself.

XhmikosR avatar May 14 '21 07:05 XhmikosR

@XhmikosR Should we roll in some Webpack or something else for the JS? I've spiked out tries at this, but haven't been happy with what I ended up with. I think we could improve our Webpack docs too in the process if we go that direction.

mdo avatar Aug 05 '21 01:08 mdo

When can we expect to have this merged?

vanillajonathan avatar Mar 01 '22 20:03 vanillajonathan

TBH, I disagree with the way we include our JS in this project. We should not import js/dist files and we certainly shouldn't promote it.

XhmikosR avatar Mar 01 '22 20:03 XhmikosR

My interest in this bootstrap-npm-starter project was just to customize the colors used by Bootstrap, so I only care about the CSS part. I don't really care about the JavaScript part at this point in time.

vanillajonathan avatar Mar 01 '22 21:03 vanillajonathan

@mdo How come you closed this?

vanillajonathan avatar Sep 02 '22 19:09 vanillajonathan

@vanillajonathan I forgot I had some open PRs here, so I cleaned house today. Everything for v5 examples and starters is at https://github.com/twbs/examples. Lots more places to start, including better starter templates and more complex JS framework setups. All our effort will go into that instead of this repo, which I'll now leave at v4 only.

mdo avatar Sep 02 '22 21:09 mdo