flink-api-examples icon indicating copy to clipboard operation
flink-api-examples copied to clipboard

Example of unit/IT test

Open danp11 opened this issue 3 years ago • 2 comments

Hi and thanks for this repo and the Flink Forward presentation. I just watch it during the weekend.

I haven't followed Flink for a couple of years now and alot of good things has been built in the Table/SQL API 👍

As this repo shows the latest func in these API I think it would be very intresting on what you consider to be "best practice" on how a unit/IT test for "Example_10_Table_Temporal_Join_Pure" would look like.

No problem of course if you dont have the time. In that case could you please point me to any tests in the Flink repo that you written and tests this kind of func?

Thanks in advance,

/Dan

danp11 avatar Feb 20 '22 11:02 danp11

Sorry, I somehow missed you opened issue in my notifications. I will try to add an example shortly. We are also planning to add an official testing util module to our code base. But until all classes that are called ITCase in the Flink code base are a good reference for testing example. Take DataStreamJavaITCase as a recent example.

twalthr avatar Apr 08 '22 14:04 twalthr

Ok ,no worries ofc. Thanks for the good work you're doing. Please don't leave as everyone else or the Table API will go vey much downhill :-)

Have a nice weekend.

Regards Dan

Den fre 8 apr. 2022 kl 16:50 skrev Timo Walther @.***>:

Sorry, I somehow missed you opened issue in my notifications. I will try to add an example shortly. We are also planning to add an official testing util module to our code base. But until all classes that are called ITCase in the Flink code base are a good reference for testing example. Take DataStreamJavaITCase https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/DataStreamJavaITCase.java as a recent example.

— Reply to this email directly, view it on GitHub https://github.com/twalthr/flink-api-examples/issues/2#issuecomment-1092946678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPXKIG2UB5RGYAFF5XWGW3VEBBTHANCNFSM5O4I7XZQ . You are receiving this because you authored the thread.Message ID: @.***>

--

Dan Pettersson

Mobile: +46 730 367 643

@.*** @.***>

www.scila.se

Scila AB, Sveavägen 17, SE-111 57 Stockholm, Sweden

danp11 avatar Apr 08 '22 20:04 danp11