apparition icon indicating copy to clipboard operation
apparition copied to clipboard

Published 20 hours ago • verified publisher icon twalpole

Fix full-page screenshots in some circumstances.

Open benpickles opened this issue 5 years ago • 4 comments

Even adding just <!DOCTYPE html> to long_page.erb will kick Chrome into a different rendering mode but setting html's height to 100% seems to be the more reliable method.

Fixes #39.

benpickles avatar Mar 05 '20 19:03 benpickles

So I just looked at an actual image from this and whilst the size of the output image is correct "below the fold" is blank/white.

I can't see that anything else is incorrect according to https://github.com/ChromeDevTools/devtools-protocol/blob/be5771fecba801dc93ab2a8e6260b2249270a7e8/types/protocol.d.ts#L9844-L9861 and https://github.com/ChromeDevTools/devtools-protocol/blob/be5771fecba801dc93ab2a8e6260b2249270a7e8/types/protocol.d.ts#L9713-L9734?

benpickles avatar Mar 06 '20 21:03 benpickles

Sorry for the delay in this - I've been really busy recently. I plan to update apparition to meet recent Capybara changes, but will hopefully get to this tomorrow

twalpole avatar Apr 04 '20 22:04 twalpole

Hmmm -- I see the issue -- not really sure how to fix, or if it is fixable - will require more research

twalpole avatar Apr 06 '20 05:04 twalpole

Yes I agree though oddly it doesn't occur with Ferrum - they even fixed the same issue recently https://github.com/rubycdp/ferrum/pull/51

benpickles avatar Apr 07 '20 18:04 benpickles