Pake icon indicating copy to clipboard operation
Pake copied to clipboard

feat: allow names with spaces (Windows & macOS)

Open g1eny0ung opened this issue 1 year ago • 4 comments

Close #873

This PR updates the name option to accept names with spaces. For example, you can use the below command to generate the app:

pake https://translate.google.com/ --name Google Translate --hide-title-bar

However, I didn't update the Linux platform's name pattern because I saw some specific rules (only lowercase letters) in the regex. @tw93 Can the Linux app name contain spaces?

g1eny0ung avatar Dec 24 '24 14:12 g1eny0ung

Linux only supports lowercase, similar to com-123-xxx, 123pan, pan123, weread, we-read. I'm wondering how to transform it into something like we-read. Could you update this PR to support it more comprehensively?

tw93 avatar Dec 26 '24 07:12 tw93

Linux only supports lowercase, similar to com-123-xxx, 123pan, pan123, weread, we-read. I'm wondering how to transform it into something like we-read. Could you update this PR to support it more comprehensively?

I guess you mean, let's say the user types in Google Translate, then we automatically convert it to google-translate in the Linux platform?

g1eny0ung avatar Dec 26 '24 07:12 g1eny0ung

Linux only supports lowercase, similar to com-123-xxx, 123pan, pan123, weread, we-read. I'm wondering how to transform it into something like we-read. Could you update this PR to support it more comprehensively?

I guess you mean, let's say the user types in Google Translate, then we automatically convert it to google-translate in the Linux platform?

yes

tw93 avatar Jan 02 '25 02:01 tw93

@tw93 Done in 785c289.

g1eny0ung avatar Jan 03 '25 08:01 g1eny0ung