brunnhilde
brunnhilde copied to clipboard
tw4l
Windows support
Windows support for scanning of directories added in release 1.6.0. Disk image support, virus scanning, and bulk_extractor support not yet included.
Hi Tessa, I'm looking into using Brunnhilde for some 'pre-ingest' work in the National Library of Ireland. It's a pretty extraordinary tool and has saved me a lot of duplicate work, and I wouldn't have made anything half as good and I certainly wouldn't have made that beautiful HTML report!
I'm hacking around a bit and have virus scanning running on windows anyhow, and bulk_extractor works well too from what I can see. I could add a PR with the updates if you wish? I should also add Windows installation remarks in the README for bulk_extractor and clamAV for windows.
One question - I'm not really familiar with tee - is there a specific reason why it's used here rather than the traditional pipe to the virus log? https://github.com/tw4l/brunnhilde/blob/main/brunnhilde.py#L191 The reason I ask is that if I just switched | tee to just >, then it should work on all operating systems.
Hi Kieran, thanks for the kind words about Brunnhilde! I'm glad that it's a good fit for you 😄
The virus scanning function was a community PR but I believe that the purpose of tee is to both redirect the output of clamAV to a log file and to display it in the console simultaneously. But you're right that we should be able to get a similar effect via means that work better for Windows.
Please do feel free to submit a PR - it would be great to get better Windows support! You might want to look at the run_bulk_extractor function here, which I rewrote for a recent release so it would work cross-platform. And do let me know if/how I can help!
Ah this is all great! I’ll hopefully send something on ASAP but with the time of year, that could slip. I do have code ready to go but I want to test it and add documentation first. Thanks for the detailed response to this and the other issue!
Hi Kieran - that sounds great! Feel free to take your time with it, and don't hesitate to ping me if you have questions or want some help :)
https://github.com/tw4l/brunnhilde/pull/55 I added clamav support there. I can also write up some windows documentation. Like I'm pretty sure that when you install BE in windows, the command line tools get added to $PATH and it just works within brunnhilde. need to test it out though. I think it should also be possible to get SleuthKit working, though I mostly deal with files/folders, not disk images.