Michael Beckwith
Michael Beckwith
## Add or edit: ### `Constant FILTER_SANITIZE_STRING is deprecated` wp-content/plugins/custom-post-type-ui/inc/post-types.php:2454 wp-content/plugins/custom-post-type-ui/inc/post-types.php:2474 wp-content/plugins/custom-post-type-ui/inc/utility.php:596 wp-content/plugins/custom-post-type-ui/inc/utility.php:603 wp-content/plugins/custom-post-type-ui/inc/taxonomies.php:2069 wp-content/plugins/custom-post-type-ui/inc/taxonomies.php:2082 Needs security sanitization reworking ### `trim(): Passing null to parameter #1 ($string) of type string...
I feel like parts of this would be really good to have once we get to the point of having stronger unit tests. I'm seeing `FILTER_SANITIZE_FULL_SPECIAL_CHARS` as available, and it...
Merged in to `release1140` branch
Fixed with https://github.com/WebDevStudios/custom-post-type-ui/pull/889
Manually merged into release1140 branch
I'm moving this to 2.0 because it's only a deprecation at the moment, and I want 2.0.0 to have majority of the Unit Testing work involved.
Moving this back to 1.14.0 and closing since we handled in PHP 8.0 compatibility check
Got this started in https://github.com/WebDevStudios/wp-search-with-algolia/tree/feature/231-remove-jquery-in-templates Needs some review/confirmation on the changing of this: ``` jQuery( '#algolia-search-box input' ).attr( 'type', 'search' ).trigger( 'select' ); ``` to something else. As is, I...
I have almost all of autocomplete.php converted except for https://github.com/WebDevStudios/wp-search-with-algolia/blob/feature/231-remove-jquery-in-templates/templates/autocomplete.php#L192-L196 I tried addEventListener but it threw errors so I'm not doing some part correct. I also interestingly needed to update...
I'm wondering if this lingering spot is maybe ok, based on https://github.com/WebDevStudios/wp-search-with-algolia/blob/main/js/autocomplete.js/dist/autocomplete.js#L1283-L1315 I don't believe the `$` is a jQuery object in this case, and I think they rolled their...