twind icon indicating copy to clipboard operation
twind copied to clipboard

@next version: the suggested upgrade code when migrating from @twind/tailwind for setup is incorrect

Open IgnusG opened this issue 3 years ago • 3 comments

The latest version .35 deprecated @twind/tailwind but the mentioned upgrade path for setup does not pass type checking (presets invalid on TwindConfig) and also does not appear to actually add the presets.

Combining setup with defineConfig seems to work however:

import { setup, defineConfig } from 'twind'
import presetAutoprefix from '@twind/preset-autoprefix'
import presetTailwind from '@twind/preset-tailwind'

// setup + defineConfig work together
export default setup(defineConfig({
  presets: [presetAutoprefix(), presetTailwind()],
  /* config */
}))

IgnusG avatar Feb 06 '22 17:02 IgnusG

Thank you! I will check the typing there.

sastan avatar Feb 15 '22 19:02 sastan

This is not forgotten. I just do not have to time ATM

sastan avatar May 09 '22 17:05 sastan

No worries 😅 Take your time

IgnusG avatar May 09 '22 18:05 IgnusG

Hey folks. This issue hasn't received any traction for 90 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it.

stale[bot] avatar Mar 05 '23 20:03 stale[bot]

Hey folks. This issue hasn't received any traction for 90 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it.

stale[bot] avatar Jan 01 '24 20:01 stale[bot]