ipod-classic-js icon indicating copy to clipboard operation
ipod-classic-js copied to clipboard

[New UI]: Implement "Songs" view

Open juampafrank opened this issue 3 years ago • 3 comments

Hey! Great work here! I have some comments, I don't know if its something that you're already working on. The first is about the filter, that is only for albums or artist, but not for songs. The second one is about the wheel and the lack of vibration when you're using it. That's all! Great work!

juampafrank avatar Jul 08 '21 04:07 juampafrank

Samsung Galaxy s10+

juampafrank avatar Jul 08 '21 04:07 juampafrank

Hey @juampafrank, appreciate the feedback! Haptic vibration was actually merged in & deployed right after you filed this ticket, so definitely let me know what you think.

Regarding a "Songs" view, that's a great suggestion! The only issue is that it requires a pagination system which I have a branch for but haven't gotten around to finishing just yet. I'm currently working on search functionality first and will then get to pagination, which in turn unlocks the ability to browse all songs.

I'm gonna keep this issue open but focus it around adding the Songs view 👍

tvillarete avatar Jul 08 '21 17:07 tvillarete

Hey @juampafrank, appreciate the feedback! Haptic vibration was actually merged in & deployed right after you filed this ticket, so definitely let me know what you think.

Hey mate did the haptic vibration implemented in this merge get patched out? iOS 15, iPhone 12.

Philbeey avatar Jul 29 '22 00:07 Philbeey