github-tagger icon indicating copy to clipboard operation
github-tagger copied to clipboard

Published 20 hours ago • verified publisher icon tvdias

Overwrite existing tag if it exists

Open tekumara opened this issue 3 years ago • 3 comments

Addresses https://github.com/tvdias/github-tagger/issues/10

tekumara avatar May 29 '21 05:05 tekumara

This PR seems to modify a ton of lines unrelated to its topic (mostly changing quote-styles, it looks like). I'm not the owner or a contributor to this repo, but maybe it'd be a more palatable PR if you trimmed it down to just one change.

waisbrot avatar Jul 02 '21 20:07 waisbrot

good point @waisbrot ... I branched off releases/v0.0.2 instead of master because I couldn't get master working... so this PR includes linter changes from 4134272 and distribution changes from ed73505 which are on the releases/v0.0.2 branch but not master

tekumara avatar Jul 03 '21 10:07 tekumara

Ugh, yeah. I just tried to make a PR for ignoring an existing tag and ran into the same problem. Github actions for JS seem like a bit of a mess (with the requirement to check in node_modules and then the commit-hook to compile TS makes the whole thing more confusing.

waisbrot avatar Jul 03 '21 11:07 waisbrot