Thomas von Deyen

Results 112 comments of Thomas von Deyen

This is much greater then the self baked solution.

Yeah @GeekOnCoffee totally right! @JDutil let's ask the community :) Let them decide. I think they would be totally fine with it. And since it will be much easier to...

Yes, translations are totally fine in `spree_i18n`, but everything else should be in the core.

Another option would be to move the globalize functionality into its own extension ('spree_globalize' for instance). Not everybody is using the model translations, but want to have the GUI translations....

@huoxito I will have a look into #532 later today, thanks for patching.

Ok, since https://github.com/spree-contrib/spree_i18n/pull/532 seems to be stalled, I will open a pull request later that removes Globalize from `spree_i18n`, so that it doesn't depend on that anymore. Then we should...

The issue that #532 tries to solve could then be handled in `spree_globalize`

Nice! Great news. I will provide a PR soon. Anyone wants to create the new repo? https://github.com/spree-contrib/spree_globalize

@alepore only if you use the new `spree_globalize` gem

Sure, it's a breaking change. Yes, you're absolutely right, 3-0-stable still needs to be fixed, though.