tuya-homebridge
tuya-homebridge copied to clipboard
tuya
Correct support of speed levels and light for Fanv2
Correctly fixes #48:
- Added support for real speed levels
- Added support for speed_enum
- Fixed turning on/off the lights in Fanv2 accessory
Hi @slavvka ,Thanks for your PR. We should have solved the adaptation problem of fans in the latest version, and adopted some of your optimization suggestions. Thanks again.
@Hanh94 the current version can only turn on and of my fan but cannot control the rotation speed. In this fix I modified the code to take the real list of possible values for the speed and use them. Also I added support for fan_speed_enum control since my fan does use it instead of fan_speed despite it exists in its config.
@Hanh94 I resolved the conflicts again. Could you please review it? I really want to have a possibility to control my fan's rotation speed.
I was unable to control my Tuya-connected Treatlife Fan switch's speed using the latest 1.4.0 plugin. I merged the above PR to my local repo, and things are working great now. Would love to see this in the official release.
@slavvka Did you ever get this resolved? I have the same issue and would love to get a fix in place. Thanks!
@slavvka Did you ever get this resolved? I have the same issue and would love to get a fix in place. Thanks!
Unfortunately the owners keep ignoring my PR :(
Just noting here that this PR continues to fix the speed control problem w/ fanv2. I had lost that control when I updated, and it took me a few days to remember that I had to manually apply this PR. Would love to see it officially merged!
Having this stagnant PR here really discourages creating new ones...
Edit: @slavvka I just noticed that the readme was updated. It seems like this is no longer maintained, or that maintenance is now handled by @0x5e on his fork. Maybe you'll have more luck creating the PR to his fork. I've just done that with my PR since seeing all the open PR made me think it might never be merged.
So frustrating indeed
From: bFollon @.> Sent: Friday, February 24, 2023 5:58:08 PM To: tuya/tuya-homebridge @.> Cc: dfizzo @.>; Comment @.> Subject: Re: [tuya/tuya-homebridge] Correct support of speed levels and light for Fanv2 (#77)
Having this stagnant PR here really discourages creating new ones...
— Reply to this email directly, view it on GitHubhttps://github.com/tuya/tuya-homebridge/pull/77#issuecomment-1444621987, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT52XE7E6CXYT5QH75ZX7SDWZE4IBANCNFSM5BG4VOFA. You are receiving this because you commented.Message ID: @.***>
they are already fixed on my fork, if anything not working for fan, you might using the non-standard device, need config manually, see my readme. @bFollon
Thanks @gaosen. Will have a look at the fork!_________________________________________Daniel M. @._________________________________________On Feb 24, 2023, at 7:14 PM, gaosen @.> wrote: they are already fixed on my fork, if anything not working for fan, you might using the non-standard device, need config manually, see my readme.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>