Sarhan Aissi

Results 37 comments of Sarhan Aissi

Strange behaviour, internally `matches` is only returning a new RegExp. Your issue may be related to the fact that your passing directly the modifiers in the regex, you are supposed...

Is the problem related to `express-validator`? Can i close this issue?

@profnandaa i was thinking about fixing it the other day and i had a little concern, should we rename ```countryCode``` to ```locale``` to have consistent naming across the lib?

@profnandaa can i work on a PR where we can accept a string and an array as a parameter and rename it to locale in the documentation?

> > I don't believe so, but using `@types/validator` in combination with this package works fine in my projects > > I missed that. Thanks, I'll let them know and...

Sorry for the long delay @Jassi10000 . Personally, i like the idea but i'm not sure about the wording. We probably need more feedback from @profnandaa and @ezkemboi

Thank you for your report, It's considered valid per-spec since `irlan` here can be considered an username in http auth. Please check the discussion in #1751 . You can pass...

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for...