Jan Larwig

> https://github.com/oauth2-proxy/oauth2-proxy/blob/a524c1fb466313c616e7699ffd557e2f8fd49aff/pkg/authentication/basic/htpasswd_test.go#L104 > > Should be `AfterEach` not `AfterSuite` Indeed this was one of the issues. Ginkgo v1 didn't really enforce that `AfterSuite` can only be defined outside of the...

I'll try to do an in-depth review soon. Unfortunately, I already have a rather large backlog.

@bbodensieck if you need any further details regarding my suggestions. Let me know here or directly get in touch via slack.

Hi yes indeed the part in `session.go#L43-45` should be removed as part of the refactoring

@jgmartinez I do have a question about the necessity of adding a roles claim. Cannot you just use the groups claim tag and use the already existing groups logic? |...

Regarding code climate, that is an unfortunate side effect of the migration towards the alpha config. As we keep a lot of "duplicate/similar" code inside the legacy files so it...

I combined the new devcontainer cli with the approach presented here: ```bash CONTAINER_NAME_OR_ID=$(devcontainer up --workspace-folder . | jq -r .containerId) /usr/bin/code --folder-uri vscode-remote://attached-container+$(printf "$CONTAINER_NAME_OR_ID" | od -A n -t x1...

> create an attached container to an existing container? How would you attach a container to a container 🤔 Or do I misunderstand what you try to accomplish?

Ah okay, if you read the last sentence of my original comment. It will answer your question: > It either starts a new devcontainer from the definition file in your...

Hi @CaedenPH, sounds like a great idea. Please feel free to open a PR for it if you would like to give it a shot.