Jan Larwig comments

Results 248 comments of


                                            Jan Larwig

feat(): add feature support for --cookie-secret-file

@sandy2008 you have one test failure in `pkg/validation/cookie_test.go` `TestValidateCookie`. You are trying to open "magic" `/tmp/cookie-secret-32.txt` which doesn't exist

REQUEST: Promotion to Reviewer for reggie-k

[Feature]: Multi-tenant / separate config per upstream

Already addressed in: https://github.com/oauth2-proxy/oauth2-proxy/pull/1923

Update oidc to not check nonce on refresh token.

First of all, you are right the refresh token is not supposed to have a `nonce`: > it SHOULD NOT have a nonce Claim, even when the ID Token issued...

Update oidc to not check nonce on refresh token.

Regarding testing we should extend the `oidc_test.go` with additional tests for the `ValidateSession` methods.

Fixed /auth endpoint returns a 202 status code regardless of whether the token has expired

Hi @mohsek, thank you for the contribution but we do have a contribution guide and a PR description template that is automatically applied when you open a PR via the...

Fixed /auth endpoint returns a 202 status code regardless of whether the token has expired

Furthermore, we need to check if this would interfere with the token refresh flow. Especially this PR: https://github.com/oauth2-proxy/oauth2-proxy/pull/1955

Fixed /auth endpoint returns a 202 status code regardless of whether the token has expired

I agree with Joel this might be a breaking change for some users. There is another PR that wants to introduce a new option to actively skip validation of expiry....

[Support]: not able to connect with keycloak

your issue is your really really old keycloak version https://oauth2-proxy.github.io/oauth2-proxy/configuration/providers/keycloak_oidc I quote: ``` --oidc-issuer-url=https:///realms/ // For Keycloak versions

Fix: Missing Resource Type "/microsoft.graph.group?" in the REST API call

@jjlakis could I have your opinion on this PR?