tutorbook
tutorbook copied to clipboard
feat(calendar): add day view
Fixes TB-136 and TB-131
TB-136 Add day view to calendar
While I'm adding the day view to our calendar, I should probably also work on fixing some of the other calendar bugs (e.g. TB-56 and TB-131).
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/tutorbook/tutorbook/3u4URDjPCAwABTt2dGxDGBQnDK3e
✅ Preview: https://tutorbook-git-calendar-tutorbook.vercel.app
Codecov Report
Merging #275 (1fc9a0c) into develop (d873ac5) will increase coverage by
1.52%
. The diff coverage is15.89%
.
:exclamation: Current head 1fc9a0c differs from pull request most recent head 2c7b2e9. Consider uploading reports for the commit 2c7b2e9 to get more accurate results
@@ Coverage Diff @@
## develop #275 +/- ##
===========================================
+ Coverage 67.46% 68.98% +1.52%
===========================================
Files 223 224 +1
Lines 4767 4788 +21
Branches 1277 1288 +11
===========================================
+ Hits 3216 3303 +87
+ Misses 1551 1485 -66
Impacted Files | Coverage Δ | |
---|---|---|
components/calendar/components.tsx | 100.00% <ø> (ø) |
|
components/calendar/daily-display.tsx | 0.00% <0.00%> (ø) |
|
components/calendar/dialog/surface.tsx | 0.00% <0.00%> (ø) |
|
components/calendar/meetings/item.tsx | 0.00% <0.00%> (ø) |
|
components/calendar/state.ts | 25.00% <0.00%> (-2.28%) |
:arrow_down: |
components/calendar/place-meetings.ts | 22.22% <25.00%> (+2.22%) |
:arrow_up: |
components/calendar/search-bar.tsx | 57.14% <50.00%> (-1.20%) |
:arrow_down: |
components/calendar/header.tsx | 59.37% <52.94%> (+13.22%) |
:arrow_up: |
components/calendar/index.tsx | 47.55% <85.71%> (+1.83%) |
:arrow_up: |
components/calendar/weekly-display.tsx | 80.82% <100.00%> (+1.09%) |
:arrow_up: |
... and 44 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3f6d194...2c7b2e9. Read the comment docs.
Test summary
Run details
Project | tutorbook |
Status | Failed |
Commit | 2c7b2e9372 |
Started | Jan 4, 2022 10:09 PM |
Ended | Jan 4, 2022 10:22 PM |
Duration | 12:51 💡 |
OS | Linux Ubuntu - 20.04 |
Browser | Chrome 96 |
View run in Cypress Dashboard ➡️
Failures
org/users/id/index.spec.ts | 3 | ||
---|---|---|---|
1 | User display page > collects profiles before booking meetings | ||
2 | User display page > lets parents book meetings for their kids | ||
3 | User display page > signs users up before booking meetings | ||
org/search.spec.ts | 3 | ||
1 | Search page > restricts access to school data | ||
2 | Search page > partitions search results by org | ||
3 | Search page > filters users by subjects, langs, and name | ||
org/signup.spec.ts | 1 | ||
1 | Signup page > validates email addresses | ||
profile.spec.ts | 1 | ||
1 | Profile page > updates volunteer profiles | ||
org/users/index.spec.ts | 1 | ||
1 | Users page > copies org links and filters users | ||
org/settings/index.spec.ts | 1 | ||
1 | Org settings page > displays and updates org settings | ||
This comment includes only the first 10 test failures. See all 11 failures in the Cypress Dashboard. |
Flakiness
profile.spec.ts | 1 | ||
---|---|---|---|
1 | Profile page > retries failed update requests | ||
login.spec.ts | 1 | ||
1 | Login page > navigates to specified redirect destination | ||
calendar.spec.ts | 1 | ||
1 | Calendar page > creates, edits, and cancels meetings |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
TB-131 Polish calendar dialog positioning
The calendar meeting dialog should be positioned better so that it's content is always fully on-screen (when the screen height is equal to or greater than the dialog content height, that is). I should try to recreate the Google Calendar dialog positioning algorithm.