tutanota icon indicating copy to clipboard operation
tutanota copied to clipboard

Links to FAQ are not always displayed as URL in Settings

Open vitoreiji opened this issue 3 years ago • 4 comments

Most of the time we display FAQ links as raw URLs, like this:

image

But in some places (at least in Settings → Subscription → Gift cards) we just make it a link with a text.

image

This should be more consistent.

vitoreiji avatar Jul 22 '21 14:07 vitoreiji

How do you like it to be, @vitoreiji ? 🙂

Idea of client rendering the FAQ url is great option if context switching is priority; if transparency is priority then we need to use full web address.

In either case, we do not have translations for FAQ's and we need to rewrite FAQ url with concat of translation code between domain and FAQ path, to make it future proof.

Happy to contribute on this issue 🐞

prnam avatar Sep 11 '21 17:09 prnam

Personally I think text links look cleaner, but I don't feel that strongly about it. I don't think there is any difference regarding transparency.

In either case, we do not have translations for FAQ's and we need to rewrite FAQ url with concat of translation code between domain and FAQ path, to make it future proof.

That's a good idea, adapting the links to the user's language to point to the FAQ in the correct language. Currently the links always go to the English FAQ.

Happy to contribute on this issue lady_beetle

That's great, thanks!

vitoreiji avatar Sep 28 '21 12:09 vitoreiji

Hey @vitoreiji , Please accept my apologies for delay in contributing on this issue. I just started to working on this few mins ago to make necessary changes.

  • Change will be as below for Gift Cards -
after-change-gift-cards-terms
  • Change in Spam rules as below -
before-spam-rule-change after-spam-rule-change

Please let me know if above is fine with you.

Help Needed - w.r.t Whitelabel. It would involve modifying translation if we replace "please see" to "more Info" with long sentence, if you want me to remove whole sentence and replace and keep it consistent like others then it will be straight forward change. Let me know you thoughts.

before-whitelabel-change

Anything if I missed as part of this change let me know, will commit & push as soon as I have your final view on this.

prnam avatar Dec 13 '21 20:12 prnam

Hey @vitoreiji @charlag @bedhub , #3744 - is related this issue. White label is untouched. If needs to be reworked or anything missed (as requested above) please let me know.

prnam avatar Dec 18 '21 12:12 prnam