tutanota icon indicating copy to clipboard operation
tutanota copied to clipboard

Pasting text into signature preview is possible

Open armhub opened this issue 3 years ago • 5 comments

If you select the "None" or "Default" email signature it is possible to paste text into the preview field. This should not be possible. Seen in the desktop client.

Test notes

  • [x] Set your signature to Default or None.
  • [x] Click on the preview and try to paste some text into it.
    • [x] Verify no text is inserted.
  • [x] Save the signature and try to edit it again.
    • [ ] Verify the signature preview is read only.

armhub avatar Feb 09 '21 13:02 armhub

Tried to fix but pasting happens before event gets triggered

ghost avatar Apr 30 '21 09:04 ghost

Apparently you can actually edit the signature preview normally too.

image

paw-hub avatar Aug 09 '22 13:08 paw-hub

This issue fails testing as the signature preview box is editable and not read-only. If you select something in the preview box, you can actually delete it.

image image

nif-tutao avatar Aug 22 '22 07:08 nif-tutao

We disabled manual editing but squire still does what it does so we need to disable squire somehow. Destroying it will not work as we pass all values though it.

charlag avatar Aug 22 '22 15:08 charlag

Editor or HtmlEditor would need a complete rewrite to make this bullet-proof, I will take this out of the milestone

charlag avatar Aug 23 '22 05:08 charlag