tuskyapp
3335: Use different bounding aspect ratios for landscape
So far I was only looking at phone resolution (in landscape). But there I think Tusky is generally unusable, regardless of used image crop aspect ratios (see screenshots in issue).
It looks ok on a tablet because that does not have a full width display.
So I guess this could be closed.
Small counterpoint to @Lakoja 's remark - I actually do use Tusky on my phone in landscape, or, well, used to before the recent aspect ratio update.
There's times it's more convenient to have my phone (Pixel 4 XL) in landscape orientation (e.g. propped up on a charging mount, so I'd need to pick it up and hold it instead), and I'd prefer to have smaller thumbnails for landscape even if it's not as usable as it would be on a tablet.
That said, feel free to do what you wish with this change.
There's times it's more convenient to have my phone (Pixel 4 XL) in landscape orientation (e.g. propped up on a charging mount, so I'd need to pick it up and hold it instead), and I'd prefer to have smaller thumbnails for landscape even if it's not as usable as it would be on a tablet.
But but but...
Do you have a screenshot for me? When I do this with my phone (which isn't especially narrow) the usable vertical space is so tiny that I dismissed this usage right away. :-)
@Lakoja
Do you have a screenshot for me?
Ack, pardon, I missed the "wanting a screenshot" part.
Here's an example of being able to read a full text post in landscape comfortably with the current stable Tusky release:
I don't have the old version of Tusky archived in order to get a screenshot of how images looked.
(In my case, I'm using Android's Gesture Navigation with the navigation hint hidden via LineageOS settings. There's a Magisk mod to do that on stock Android builds, too. Even without that, it only would've partially cropped out the interaction buttons, none of the actual post.)
Why is this still draft? Its definitely an improvement, would merge.
Not quite sure if it is an improvement for landscape tablet resolutions (which have quite ok-ish height). I noticed for example that many images - at least at that time in my feed - have a 1:1 ratio. Going with 1.2 as min aspect ratio would have cut all those noticeably (that's why I changed it to 1.0 as minimum).
But I un-drafted it now. Maybe somebody (more than one) would like to test it and if necessary we can fine-tune then.
To confirm, what kind of testing in landscape mode would be helpful to get this merged?
I have a Pixel 4 XL and some older, rather slow devices (Nexus 6 on Android 8.1, Galaxy Nexus on Android 6.0). To get an APK, I assume I'd just need to follow the usual Tusky development build steps with this PR as the base.
Tusky development build steps with this PR as the base.
Hi. Thank's for your offer. You can compile it and install it as a development version from this branch, yes. If you're somewhat familiar with this, it's ok.
However, I think this might be (discussed internally and) merged, so it can be tested more easily from the nightly version. I'm not sure however when that might be.
Do we need more testing on this? Should we just merge it and see what nightly users say?
Do we need more testing on this? Should we just merge it and see what nightly users say?
Probably not (merge it).
I tested this again and see three classes of devices:
- The standard case: Normal phones (or also tablets) in portrait mode
- Normal phones in landscape mode: This is (mostly) discussed and tested here
- Tablets in landscape mode: Tusky seems to have a width limit for the content and thus the area of the timeline is also more high than wide
So the largest portion of devices including all tablet orientation do not have a problem.
Only the landscape phones would benefit here. But the current improvement (this PR) targets all landscape devices.
So, if we want to merge this we would first need to specifically only target landscape phones.