ToDoList icon indicating copy to clipboard operation
ToDoList copied to clipboard

Published 20 hours ago • verified publisher icon tusharnankani

Remove scrollbar

Open ninadnaik10 opened this issue 1 year ago • 2 comments

I noticed that when deleting a task, the task falls and scrollbar appears. The scrollbar shrinks the page for a moment which does not look good. So I hid it from the body tag. I know this approach is not good for accessibility but it would help the webpage look nicer.

ninadnaik10 avatar Aug 31 '22 16:08 ninadnaik10

Hi @ninadnaik10

Thank you for opening this PR. I faced this issue in #22, and at that point in time, I thought it was fixed. But now, if you try to add more that 7-8 todos (in 100% desktop size), you'll realize, you won't be able to scroll.

PS: Try your deployed PR here: https://deploy-preview-29--tusharjustdoit.netlify.app

So, implementing a fix like this or what was done earlier; is like hiding the problem, rather than fixing it.

Thank you for bringing this to my notice. Will be reopening #22 and the fix is to always have a scrollbar fixed. So, the screen doesn't shrink — when the scrollbar appears.

Would you like to work on this PR?

tusharnankani avatar Sep 01 '22 10:09 tusharnankani

Hi @tusharnankani I saw the deployed PR and it seems an issue. I would like to work on this PR. Thank you!

ninadnaik10 avatar Sep 01 '22 12:09 ninadnaik10