tusd
tusd copied to clipboard
v2: Next major version
Tasks to be done:
General
- [ ] change go.mod to ../v2 and update internal references to .../v2 (see https://github.com/tus/tusd/pull/672#issuecomment-1082737523)
Hooks
- [ ] docs: Update documentation about hooks
- [ ] docs: Add plugin hooks to documentation
- [ ] cli: Consider moving hooks in
pkg/
- [ ] cli: Add tests for hook implementations and system
- [ ] handler: Allow modifying the HTTP response when stopping an upload
- [ ] grpc: Add headers to hook request
- [ ] grpc: Add documentation to proto files
- [ ] grpc: Move proto file into better, public location
- [ ] plugin: Stop zombie processes when tusd terminates
- [ ] plugin: Move into public package. The plugin should not import for the cmd directory
- [ ] plugin: Clean up hooks/plugin.go
Locking
- [ ] Implement functionality for filelocker
- [ ] Adapt implementation at tusd-etcd-locker
- [ ] Add tests for new functionality in handler
- [ ] Increase default read timeout to reduce their likelihood
Somewhere in your checklist, you should also add change go.mod to ../v2 and update internal references to .../v2
(see https://go.dev/doc/modules/major-version) - automated tool: https://github.com/marwan-at-work/mod
Currently the v2
is not importable as a go package:
~ go get github.com/tus/[email protected]
go: github.com/tus/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/tus/tusd/v2")
~ go get github.com/tus/tusd/[email protected]
go: github.com/tus/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/tus/tusd/v2"
Thanks for the hint, @oliverpool. We need to look into this, you are right.
@oliverpool I just fixed the module import in https://github.com/tus/tusd/pull/672/commits/a75c24996f37f5c9635390b9746f178967d66513 as you explained in your comment. Could you test it out and let us know if there still is a problem?
There are still some TODOs, but they can be addressed once this has been merged in main.