tus-py-client icon indicating copy to clipboard operation
tus-py-client copied to clipboard

Add support for client certificates

Open quality-leftovers opened this issue 2 years ago • 3 comments

Support authenticating using client certificates (#84).

quality-leftovers avatar Oct 26 '23 12:10 quality-leftovers

Wondering if you could have a look again. Still not sure what to do related to the tests since TLS cannot really be tested in the unit tests.

quality-leftovers avatar Feb 21 '24 15:02 quality-leftovers

Sure, I responded to your latest comments :)

Acconut avatar Mar 04 '24 07:03 Acconut

One additional thing: Please avoid force pushing to the branch. This makes it harder for us to review changes as we don't know what changes between commits. In the end, the entire branch will be squashed anyways, so the Git commits don't matter much.

Acconut avatar Mar 25 '24 08:03 Acconut

What's the status of this PR, do you guys welcome contributions?

We need this functionality as well and I've tested against local nginx instance enforcing client authentication that hard coding the certs in place in uploader.py, baseuploader.py and request.py works.

jukuisma avatar Nov 26 '24 09:11 jukuisma

I haven't had a look at this recently, but we can merge this now. It should work as we expect and if not, we can always ship additional updates later. Thank you @quality-leftovers for contributing this feature!

Brilliant, I can start testing against this instead of my hard coded patches. Thanks!

jukuisma avatar Nov 26 '24 11:11 jukuisma