Add support for client certificates
Support authenticating using client certificates (#84).
Wondering if you could have a look again. Still not sure what to do related to the tests since TLS cannot really be tested in the unit tests.
Sure, I responded to your latest comments :)
One additional thing: Please avoid force pushing to the branch. This makes it harder for us to review changes as we don't know what changes between commits. In the end, the entire branch will be squashed anyways, so the Git commits don't matter much.
What's the status of this PR, do you guys welcome contributions?
We need this functionality as well and I've tested against local nginx instance enforcing client authentication that hard coding the certs in place in uploader.py, baseuploader.py and request.py works.
I haven't had a look at this recently, but we can merge this now. It should work as we expect and if not, we can always ship additional updates later. Thank you @quality-leftovers for contributing this feature!
Brilliant, I can start testing against this instead of my hard coded patches. Thanks!