matrix-bot-sdk icon indicating copy to clipboard operation
matrix-bot-sdk copied to clipboard

Remove Sled crypto store, use SQLite by default

Open AndrewFerr opened this issue 2 years ago • 3 comments

on account of it being removed from the crypto-sdk

Signed-off-by: Andrew Ferrazzutti [email protected]

Checklist

  • [x] Tests written for all new code
  • [x] Linter has been satisfied
  • [x] Sign-off given on the changes (see CONTRIBUTING.md)

AndrewFerr avatar Jul 17 '23 13:07 AndrewFerr

I'm honestly more inclined to replace the rust-sdk with something else. These zero-notice and breaking changes are becoming more hassle than it's worth.

A migration path needs to be present for this SDK to drop sled, and the SDK will need to automatically do it in order to avoid a breaking change itself.

turt2live avatar Jul 17 '23 14:07 turt2live

A migration path needs to be present for this SDK to drop sled, and the SDK will need to automatically do it in order to avoid a breaking change itself.

I've opened an issue to track this: https://github.com/vector-im/matrix-bot-sdk/issues/26

AndrewFerr avatar Aug 02 '23 21:08 AndrewFerr

It looks like the rust-sdk bindings have stablized a bit since this was opened, which is great. I'm tempted to land this in a v1.0.0 of the bot-sdk, as it's a breaking change.

turt2live avatar Oct 11 '23 22:10 turt2live